Skip to content

Debit Card Feature - #181

Open
juankamilo wants to merge 18 commits into
ebanx:masterfrom
juankamilo:master
Open

juankamilo wants to merge 18 commits into
ebanx:masterfrom
juankamilo:master

Conversation

@juankamilo

@juankamilo juankamilo commented Nov 17, 2020

Copy link
Copy Markdown

Debit Card Feature

At the moment the default library doesn't have the complete implementation for Debit Cards.
Some validations of the fields that must be sent use the Credit Card model, so the transactions fail
We send our implementation, in case it helps you

Added Debit Card feature 
At the moment the default library doesn't have the implementation for Debit Cards, We will send the implementation request.
@codecov-io

codecov-io commented Nov 17, 2020

Copy link
Copy Markdown

Codecov Report

Merging #181 (bdb40d4) into master (cec91fe) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   98.21%   98.24%   +0.02%     
==========================================
  Files          58       59       +1     
  Lines        1067     1081      +14     
==========================================
+ Hits         1048     1062      +14     
  Misses         19       19              
Impacted Files Coverage Δ
src/Services/Adapters/DebitCardPaymentAdapter.php 100.00% <100.00%> (ø)
src/Services/Gateways/DebitCard.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec91fe...bdb40d4. Read the comment docs.

@codecov-commenter

codecov-commenter commented Feb 25, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.68%. Comparing base (f556691) to head (c472e66).
⚠️ Report is 14 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #181      +/-   ##
============================================
+ Coverage     97.65%   97.68%   +0.03%     
- Complexity      366      368       +2     
============================================
  Files            71       72       +1     
  Lines          1064     1078      +14     
============================================
+ Hits           1039     1053      +14     
  Misses           25       25              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants