Repository navigation
fix(v1): preserve migration scope, module filters and internal aliases - #234
Merged
Merged
Conversation
Yakwilik
changed the title
Yakwilik
changed the title
Yakwilik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy directory inputs migrate without moving proto sources or widening generation to Gradle copies. Literal generate.paths now uses the selected module directory as its base: roots api plus paths api/easyp preserves imports easyp/... . A sole local module is inferred rather than repeated, and migration omits unconfigured options.go.package_prefix.
Module entries accept the existing string shorthand or an object with module, paths and packages. Global filters remain available without listing modules and intersect scoped filters. Scoped selectors must match their own module; global selectors match across final selected sources. Unknown selectors and conflicting duplicate module selections fail before plugins or descriptor writes, including no-plugin projects and --all.
Bounded file, directory/import-root and metadata aliases share one source view. Local reads use os.Root; Git dependencies and breaking baselines read immutable tree/blob objects and materialize regular bytes under logical names. Current/baseline paths, filters and openers remain separate. Selected unsafe inputs fail; unrelated auxiliary failures and opaque descendant Gitlinks do not poison consumers. There is one current v1 h1 snapshot/cache policy, with no previous-nightly compatibility path. Historical migration verifies its archive layouts separately. SHA-256 Git identity and host spelling collisions are checked.
Validation at this head: Go 1.26.6; full source race tests; complete standard v1 suite with fresh CLI/MCP and matching source; compiled SDK scenarios for global/scoped selectors; pinned lint (0 issues); reproducible schemas; independent review/probes; real protoc-gen-mcp/service copies migrate, generate in frozen mode and compile. Proto names/bytes are preserved. Go module dependencies are unchanged.
Limits: existing BSR compatibility snapshots do not verify revision equivalence/digests. The protoc-gen-mcp broad test suite still has v0 command fixtures; generated build/runtime checks were evaluated separately. Docs MDX/types pass; the previously attempted production build was blocked fetching Google Fonts.