Skip to content

[25517] Change JavaScript engine to Mozilla Rhino - #598

Merged
MiguelCompany merged 2 commits into
3.3.xfrom
backport/js-engine/3.3.x
Jul 22, 2026
Merged

[25517] Change JavaScript engine to Mozilla Rhino#598
MiguelCompany merged 2 commits into
3.3.xfrom
backport/js-engine/3.3.x

Conversation

@MiguelCompany

@MiguelCompany MiguelCompany commented Jul 21, 2026

Copy link
Copy Markdown
Member

Description

This PR changes the JavaScript engine used for evaluating constant expressions to Mozilla Rhino, which has a license compliant with the Apache 2.0 license used in this project.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v3.3.3 milestone Jul 21, 2026
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jul 21, 2026
@MiguelCompany MiguelCompany changed the title Refs #25517. Change JavaScript engine to Mozilla Rhino. [25517] Change JavaScript engine to Mozilla Rhino Jul 21, 2026
@mergify

mergify Bot commented Jul 21, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

ZakariaTalbi

This comment was marked as outdated.

@MiguelCompany
MiguelCompany deleted the backport/js-engine/3.3.x branch July 22, 2026 05:55
@MiguelCompany MiguelCompany reopened this Jul 22, 2026
ZakariaTalbi

This comment was marked as outdated.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
MiguelCompany force-pushed the backport/js-engine/3.3.x branch from f0e6b46 to afa23a7 Compare July 22, 2026 08:03

@ZakariaTalbi ZakariaTalbi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany
MiguelCompany merged commit a473147 into 3.3.x Jul 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants