Skip to content

[24122] Fix warning on ubuntu noble (backport #133) - #135

Merged
cferreiragonz merged 1 commit into
2.0.xfrom
mergify/bp/2.0.x/pr-133
Jul 21, 2026
Merged

[24122] Fix warning on ubuntu noble (backport #133)#135
cferreiragonz merged 1 commit into
2.0.xfrom
mergify/bp/2.0.x/pr-133

Conversation

@mergify

@mergify mergify Bot commented Jan 27, 2026

Copy link
Copy Markdown

Description

This PR fixes:

../../eprosima/discovery-server/src/DiscoveryServerManager.cpp: In member function ‘void eprosima::discovery_server::DiscoveryServerManager::loadClient(tinyxml2::XMLElement*)’:
../../eprosima/discovery-server/src/DiscoveryServerManager.cpp:1106:28: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
 1106 |                     if (p4 = std::dynamic_pointer_cast<TCPv4TransportDescriptor>(sp))
      |                         ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@Mergifyio backport 2.1.x 2.0.x 1.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The added tests pass locally.
  • Changes are backwards compatible.
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #133 done by [Mergify](https://mergify.com).

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit cb2addc)
@mergify mergify Bot mentioned this pull request Jan 27, 2026
10 tasks
@cferreiragonz cferreiragonz added this to the v2.0.2 milestone Jan 27, 2026
@cferreiragonz
cferreiragonz merged commit 93dd0e1 into 2.0.x Jul 21, 2026
4 checks passed
@cferreiragonz
cferreiragonz deleted the mergify/bp/2.0.x/pr-133 branch July 21, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants