Skip to content

fix(embed): enable build rootfs disk growth #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
selamanse wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(embed): enable build rootfs disk growth #3680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions embed/compose/compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,8 @@ services:
# pause-admission-disk-headroom-mib flag, which has no LaunchDarkly to
# come from here; orchestrator releases that predate the knob ignore it.
PAUSE_ADMISSION_DISK_HEADROOM_MIB: "1024"
# Grow the build rootfs after build steps so larger code tasks have room.
BUILD_ENSURE_FREE_DISK_SPACE: "true"
BUILD_CACHE_STORAGE_URL: file:///var/lib/e2b/storage/build-cache
ARTIFACTS_REGISTRY_PROVIDER: Local
LOCAL_UPLOAD_BASE_URL: http://127.0.0.1:5008
Expand Down
3 changes: 2 additions & 1 deletion packages/shared/pkg/featureflags/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,8 @@ var (
ExpirationIndexHealerFlag = NewBoolFlag("expiration-index-healer", true)

// BuildEnsureFreeDiskSpace grows the rootfs after build steps and before finalize.
BuildEnsureFreeDiskSpace = NewBoolFlag("build-ensure-free-disk-space", false)
// Embed has no LaunchDarkly instance, so allow it to opt in through the environment.
BuildEnsureFreeDiskSpace = NewBoolFlag("build-ensure-free-disk-space", envBoolOr("BUILD_ENSURE_FREE_DISK_SPACE", false))
)

// envdTimeoutFallbackMs reads ENVD_TIMEOUT (Go duration string, e.g. "10s")
Expand Down