Repository navigation
fix(api): keep allocations unchanged on NotFound - #3677
Open
perfloop-agent wants to merge 1 commit into
Open
perfloop-agent wants to merge 1 commit into
perfloop-agent wants to merge 1 commit into
Conversation
Signed-off-by: Perfloop Agent <agent@perfloop.ai> Signed-off-by: Tomás Senart <ts@perfloop.ai>
perfloop-agent
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
October 11, 2026 00:17
Contributor
|
Hi, I'm Tomás, I build Perfloop. I approved this contribution and will handle review feedback here. We've had performance PRs merged in ClickHouse, Prometheus, Ruff/ty, parquet-go, RoaringBitmap, and more, including an earlier orchestrator fix here that you merged. This one keeps allocations unchanged when the API returns NotFound. Happy to reshape anything to fit how you'd like it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
killSandboxOnNodesubtracts a sandbox's resources whenDeletereturnsNotFound. If a newer node report already removed the sandbox from the totals, this subtracts it twice.Return on
NotFoundbefore updating the counters. The test fails on the old code and passes with this change. It also covers successful deletes and other errors.Allocations can remain over-counted until the next node report, normally every 20 seconds. Successful deletes can still race with node reports.
Full API tests, including ARM64 execution, still need upstream CI.
Found by Perfloop.