-
Notifications
You must be signed in to change notification settings - Fork 1k
test: mock all template build tests #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
devin-ai-integration
wants to merge
2
commits into
main
from
devin/1787255437-mock-template-build-tests
+745
−221
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,26 @@ | ||
| import { randomUUID } from 'node:crypto' | ||
| import { expect, test } from 'vitest' | ||
| import { afterAll, beforeAll, expect, test } from 'vitest' | ||
| import { setupServer } from 'msw/node' | ||
| import { Template } from '../../src' | ||
| import { TEST_API_KEY } from '../setup' | ||
| import { createMockBuildApi } from './mockBuildApi' | ||
|
|
||
| const server = setupServer(...createMockBuildApi().handlers) | ||
|
|
||
| beforeAll(() => server.listen({ onUnhandledRequest: 'error' })) | ||
| afterAll(() => server.close()) | ||
|
|
||
| // The placeholder key keeps the mocked template tests independent of | ||
| // E2B_API_KEY being set in the environment. | ||
| const apiKey = process.env.E2B_API_KEY ?? TEST_API_KEY | ||
|
|
||
| test('check if base template name exists', async () => { | ||
| const exists = await Template.exists('base') | ||
| const exists = await Template.exists('base', { apiKey }) | ||
| expect(exists).toBe(true) | ||
| }) | ||
|
|
||
| test('check non existing name', async () => { | ||
| const nonExistingName = `nonexistent-${randomUUID()}` | ||
| const exists = await Template.exists(nonExistingName) | ||
| const exists = await Template.exists(nonExistingName, { apiKey }) | ||
| expect(exists).toBe(false) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T-50 — an env var set to the empty string means unset.
??only falls through onundefined/null, so an exported-but-emptyE2B_API_KEY=''gets passed as an explicit (highest-precedence)apiKeyoption and reaches the transport as a malformed credential instead of falling back toTEST_API_KEY.The same pattern appears in the other new fallbacks:
template/backgroundBuild.test.ts:15,template/exists.test.ts:15, andtemplate/tags.test.ts:64.