Add Pracht - #439
Add Pracht#439JoviDeCroock wants to merge 2 commits into
Conversation
225d9c0 to
1d7f71f
Compare
|
haven't read through yet but seems like a good addition to have! very interested to see how it compares to the others |
|
Thank you for the PR. I will need some time to review this in detail. I will review each test setup and may have follow-up questions about framework-specific points that need to be added to the methodology. @43081j Do we include this in Focused Frameworks or all. I lean towards all based on popularity? |
|
Hey @JoviDeCroock Sorry to do this, but I have been going through a bunch of changes to get the base frameworks signed off. Some of them have been big, adding new tests and even changing some of the config. I should be finished by the end of next week and will update the contribution guide with what you need to change. Could you update this PR after that for me? Once again, sorry just a lot of tweaks getting all the framework authors to sign off |
|
@JoviDeCroock Version one of the tests is pretty stable now so ready for this to be tweaked and added in |
Adds `starter-pracht` and `app-pracht`, plus the stats-generator wiring (production serve script, in-process SSR request handler, and entries in the ssrRequestThroughput / ssrLoad / clientSideRendered / serverSideRendered registries), a `.github/frameworks.json` entry, and docs-site wiring. Pracht is a Preact meta-framework on Vite (https://github.com/JoviDeCroock/pracht). `starter-pracht` is the output of `pnpm create pracht@latest --no-agent-tools` with the remaining recommended defaults (Node adapter, manifest router, no Tailwind). The generated `Dockerfile` and `.dockerignore` are dropped since no measurement uses them, dependency versions are pinned exact, and the files are formatted with the repository's Prettier config. `app-pracht` mirrors the other `app-*` packages: SSR routes load from `packages/testdata`, the client-side-rendered route uses `render: "spa"` and generates its rows in the browser, and every route keeps the default `hydration: "full"` so it is measured like the other hydrating frameworks.
0396f2a to
8f36ed6
Compare
3 participants
Adds Pracht, a Preact meta-framework built on Vite, as a tracked framework.
I'm the author of Pracht, so treat the choices below as "here's what the CLI does", not advocacy.
Note
This PR was co-authored by an agent and reviewed by myself
What's here
packages/starter-pracht/— the Node/manifest-router starter, pinned to@pracht/core0.18.0 and the matching current Pracht packages, with a first-party dependency manifest.packages/app-pracht/— benchmark routes, including separate ordinary-anchor and router-<Link>SSR load routes.packages/stats-generator/— production server and in-process SSR handler, browser-rendering and throughput registries, and paired SSR load configuration.No
ci-stats.json— CI generates those on the Depot runners.Benchmark choices
packages/testdata. Plain-link and router-link SSR load pages differ only in link implementation./client-side-renderedusesrender: "spa"and generates 1,000 rows in the browser.fullDocumentNavigation: falsein browser benchmark registries: Pracht uses client-side navigation. Default intent prefetch on<Link>is left on.Verification
/ssr-throughput; both load-route HTML responses passed the harness table verifier. The SPA route returned an empty SSR table, as intended.Checklist
If updating UI/UX components ensure you have added screenshots or a gif or video of the changes to the PR description
N/A — docs changes are assets, chart mappings, and Markdown.
If this is a dependabot PR that bumps a metaframework version, ensure that all package versions in the package match the versions installed by the metaframework version being bumped
N/A — this is not a dependabot PR.
If this is a dependabot PR that bumps a metaframework version in a
starter-*package, ensure that the deps, and file content matches the output of the metaframeworks recommended starter/default projectN/A — this is not a dependabot PR.