Repository navigation
ci: build flatpak from a commit instead of a branch name - #889
Merged
Merged
Conversation
dynobo
force-pushed
the
ci/flatpak-build-by-commit
branch
from
October 20, 2026 20:56
9550d73 to
1821d95
Compare
PRs from forks have head branches that don't exist in dynobo/normcap, so `update.py --bundle <branch>` failed with "Remote branch not found", and the GitHub API lookup in the build script returned 422 for such names. Pass a commit instead: `github.sha` is the PR merge commit (the tree the other jobs test), the pushed commit for pushes and the tag's commit for tags. Only `workflow_dispatch` still builds the given ref, which now also accepts SHAs. Branch names from PRs in this repo still work, but the manifest is now pinned to an exact commit, making the build reproducible. Also drop the write-only REPO/BRANCH env block of the clone step. Requires the flathub repo's update.py to support SHA sources: flathub/com.github.dynobo.normcap#141
dynobo
force-pushed
the
ci/flatpak-build-by-commit
branch
from
October 20, 2026 21:01
1821d95 to
90f0688
Compare
Collaborator
|
coverage: 80.915%. remained the same — ci/flatpak-build-by-commit into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-flatpak→ "Run build script" fails for every PR whose head branch does not live indynobo/normcap(Weblate, Dependabot, external contributors):