Found while reviewing docs in PR #30, not fixed there since it touches a code sample.
File: license/ensure-no-overuse.md, around line 54-56
The C++ sample declares a settings object as settings on line 54, but then references it as setting (singular) on line 56:
settings.someOtherField = ...; // line 54, declared as `settings`
...
setting.maxParallelTasks = licenseCount; // line 56, typo'd as `setting`
This won't compile as written.
Separately, the same sample calls SetMaxConcurrentInstanceCount after InitLicense, which is the opposite order from the C++ and Python samples elsewhere in the same file. Worth double-checking which order is actually correct/required and making the samples consistent.
Found while reviewing docs in PR #30, not fixed there since it touches a code sample.
File:
license/ensure-no-overuse.md, around line 54-56The C++ sample declares a settings object as
settingson line 54, but then references it assetting(singular) on line 56:This won't compile as written.
Separately, the same sample calls
SetMaxConcurrentInstanceCountafterInitLicense, which is the opposite order from the C++ and Python samples elsewhere in the same file. Worth double-checking which order is actually correct/required and making the samples consistent.