Add a security policy#1
Merged
Merged
Conversation
States the threat model explicitly: what reaches the model, why pull_request_target is safe here and the one thing that would make it unsafe, who can spend the key, and that there is no dist/ to audit.
A fork PR, or a clone without LLM_API_KEY, was failing the check rather than skipping it. The secrets context is not available in a job-level if:, so gate the step on an env expression instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the threat model: what reaches the model, why
pull_request_targetis safe with this action and the one thing that would break that, who can spend the key, and the absence of a bundleddist/.Also serves as the first live run of the action on a real runner.