Fix SwiftUI Section builder issues for Swift 6 migration#274
Open
dylans2010 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@ViewBuilderinference rejects non-Viewexpressions placed directly inSectionbodies, causing build errors during migration.letbindings and computed expressions insideSectionclosures which must be moved or wrapped so the Section body only returns views.Description
FilePreviewView's "Content"Sectionwith aGroupand removed an inlineletso theSectionbody contains only view-producing code (SwiftCode/Views/Utilities/FilePreviewView.swift).Sectionbody into a computed propertydeploymentLogsand updated theSectionto use it (SwiftCode/Views/Developer/DeploymentDebug/DeploymentDebugView.swift).Sectionbody into a computed propertysourceBranchCommitsand updated theSectionto iterate that property (SwiftCode/Views/Collaboration/PRCreateView.swift).Sectionclosures contain only view-building code and avoid non-Viewbindings that trigger Swift 6 builder errors.Testing
xcodebuild -project SwiftCode.xcodeproj -list, but it failed because Xcode CLI tools are not available in the environment (xcodebuild: command not found), so a full build/test could not be executed.git commit) successfully, indicating the patches applied cleanly.Codex Task