Skip to content

Feature: Android support - #517

Open
alphaxleonidas wants to merge 27 commits into
dyc3:masterfrom
alphaxleonidas:testing
Open

Feature: Android support#517
alphaxleonidas wants to merge 27 commits into
dyc3:masterfrom
alphaxleonidas:testing

Conversation

@alphaxleonidas

@alphaxleonidas alphaxleonidas commented Sep 4, 2026

Copy link
Copy Markdown
  • Added a new profile Termux in Cargo.toml for consistent Android builds.
  • Added docs for building on Mobile (Android)

Limitation: Keyring feature will not work, hence removed in the compiled binary.

Untested:

  • Out of the main features qr-login has not been tested. Tested and works fine.
  • Creating an Android build on PC should be possible but has not been tested. Instructions available on the fork's main page.

Disclaimer: AI used.

Updated README to include build instructions for PC and Android, added running instructions for Android using Termux, and clarified the legitimacy of the original repo for downloading binaries.
Emphasize links in the README by making them bold.
Updated the guide link for running on Android with Termux.
Added a note about the lack of issues with the Android version of steamguard-cli.
Corrected formatting and wording in the README file for clarity.
Removed outdated testing branch information and added build instructions for steamguard-cli-android.
Corrected typos and improved clarity in instructions.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The Termux guide currently contains broken instructions and directs users to a third-party binary that conflicts with this project's provenance policy.

Reviewed changes Android support was reviewed across the new low-memory Cargo profile, README integration, and the complete Termux build and usage guide.

  • Termux build profile — Adds a release-derived profile with lower optimization and LTO disabled for constrained on-device builds.
  • Android entry points — Advertises Android operation and the lack of keyring support from the main README.
  • Build and usage guide — Documents Termux installation, source and binary acquisition, compilation, PATH setup, and maFile setup/import flows.

ℹ️ Android support is not regression-tested

No Android-target build is exercised by the current CI or release workflow, so future dependency changes can silently invalidate the newly documented support. The exact feature/profile combination passes a host cargo check, but that does not validate linking against Android or preserve an upstream Android artifact.

Technical details
# Keep Android support reproducible

## Affected sites
- `.github/workflows/rust.yml:34` — CI cross-checks only desktop targets.
- `.github/workflows/release.yml:23-47` — the release matrix has no Android target.

## Required outcome
- Add an Android-target build check, or explicitly document Android support as a best-effort, manually tested on-device path with no upstream binary guarantee.

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow run | Using GPT Sol (free via Pullfrog for OSS) | 𝕏

Comment thread docs/TERMUX_BUILD.md Outdated
Comment thread docs/TERMUX_BUILD.md
Comment thread docs/TERMUX_BUILD.md Outdated
Comment thread docs/TERMUX_BUILD.md
Updated instructions for Termux storage setup to reflect the correct command.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

No new issues were found in 2600636; the two remaining threads from the prior review still require action before merge.

Reviewed changes Reviewed the documentation corrections made since the prior Pullfrog review.

  • Cross-compilation guidance — Removed the dead reference to the deleted docs/ANDROID.md guide while preserving the scope of the Termux instructions.
  • Storage setup command — Corrected the troubleshooting note to use the valid termux-setup-storage command.

Pullfrog  | Fix it ➔View workflow run | Using GPT Sol (free via Pullfrog for OSS) | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant