fix: 2FA secret QR code for Bitwarden/KeePassXC needs to be Base32 encoded instead Base64 - #516
Merged
Merged
Conversation
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
The required Rust formatting check fails on the added test code; apply cargo fmt before merging.
Reviewed changes Reviewed the complete one-file change to QR payload generation and its tests.
- Secret encoding — Converts decoded Steam shared-secret bytes to uppercase, unpadded RFC Base32 for Bitwarden and KeePassXC exports.
- Payload extraction — Moves format-specific URI generation into
QrCommand::qr_contentso it can be exercised directly. - Coverage — Adds RFC Base32 vectors and checks both password-manager payloads while preserving the Steam URI path.
GPT Sol (free via Pullfrog for OSS) ｜ 𝕏
…coded instead Base64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to fix #515.
Disclaimer: PR is done with help of coding agent.