Remove align-items: center override on dropdown wrapper - #838
Merged
Conversation
The theme's .bs-dropdown-wrapper rule set align-items: center, which overrode the bs-dropdown-extended plugin's align-items: stretch. This caused the caret button to collapse to the intrinsic height of its triangle icon instead of stretching to the full menu bar height, reducing the clickable area well below WCAG AAA touch target size. Fixes: #837
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Solution
The theme's
.nav > li > .bs-dropdown-wrapperrule indxpr-theme-header--top.scsssetalign-items: center, overriding thebs-dropdown-extendedplugin'salign-items: stretch. This caused the caret<button>to collapse to the intrinsic height of its triangle icon (~12px) instead of stretching to the full menu bar height.The fix removes
align-items: centerfrom the wrapper rule, allowing the plugin'sstretchto take effect. Both the nav link and the caret button now fill the full wrapper height, restoring WCAG AAA compliant touch target sizing.The affix/scroll state (line 104) is unaffected because its wildcard selector
.bs-dropdown-wrapper > *already sets explicit height on all children including the caret.The mobile mode has no
align-itemsoverrides on wrapper elements and is not affected.Checklist