WebGPU: remove leftover diagnostic scan from the uniform-set bind hot path - #8
Open
octopusburrow wants to merge 1 commit into
Open
WebGPU: remove leftover diagnostic scan from the uniform-set bind hot path#8octopusburrow wants to merge 1 commit into
octopusburrow wants to merge 1 commit into
Conversation
… bind hot path The scan iterated every bound texture against every framebuffer attachment on each command_bind_render_uniform_sets call, and its body only increments a local counter — the print it fed was removed. In any scene that never reaches 20 matches it runs for the whole session, on the hottest CPU path, twice per frame in two-pass XR. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sync-conflict diagnostic in
command_bind_render_uniform_setsiterates every boundtexture against every framebuffer attachment on each call, and its body only increments
a function-local counter — nothing reads it, in any build configuration, and no print
consuming it exists anywhere in the history available on either the fork or upstream
(the surviving "limited to a few prints" comment suggests one once did). The scan runs
on every uniform-set bind of every draw — in both eye passes under two-pass XR — and in
any scene that never reaches its 20-match cap it runs for the whole session. Pure
deletion; no behavior change.