Repository navigation
Upgrade helm/k8s/cel-go deps; tighten docs wording - #1
Merged
Merged
Conversation
- helm.sh/helm/v4 v4.2.2 -> v4.3.0
- k8s.io/{api,apimachinery,cli-runtime,client-go} v0.36.2 -> v0.37.1
- cel-go v0.29.0 -> v0.32.0; the module moved to cel.dev/cel-go, so
the imports in internal/spec/when.go follow it. khook is the only
importer of cel-go in the binary, so only one copy is linked.
- santhosh-tekuri/jsonschema v6.0.3, go.yaml.in/yaml/v3 v3.0.5,
golang.org/x/term v0.46.0; indirect deps follow via MVS.
- go directive 1.26.4 -> 1.26.8 (latest 1.26 patch; CI reads it
through go-version-file).
README badge and the AGENTS.md size note are updated to match; the
release binary is now ~68 MB.
Shorter, plainer prose with the same content. Drops the pitch-style
lines ("feared by everyone on call", "sleep-and-pray", "turf war",
"That's the point"), most em-dash asides, and stale asides such as the
"v0-proven" notes and the claim that v0 examples live in-tree.
- dsl.md / cli.md: same rules, tables, and examples; headings kept
so existing #anchors still resolve. The duplicated remote-content
caveat in state: now lives only under the tradeoffs.
- README, getting-started, examples, vs-terraform, ROADMAP: trimmed.
- index.html, 404.html, _config.yml: copy only, markup unchanged.
Runs clean (0 issues) against the upgraded module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes, one commit each (plus a CI pin bump), so they can be reviewed separately.
Dependency upgrade
helm.sh/helm/v4k8s.io/{api,apimachinery,cli-runtime,client-go}github.com/google/cel-gov0.29.0cel.dev/cel-gov0.32.0santhosh-tekuri/jsonschema/v6go.yaml.in/yaml/v3golang.org/x/termgodirectivecel.dev/cel-goin v0.32, so the imports ininternal/spec/when.gochange with it. khook is the only package in the binary that imports cel-go (k8s apiserver still requires the old path, but none of its CEL packages are linked), so the binary contains one copy.go get -u ./...on everything pulls akube-openapipseudo-version that requires Go 1.27.Docs pass
The goal was shorter, plainer wording with the same content. I removed the pitch-style lines ("feared by everyone on call", "sleep-and-pray", "turf war", "That's the point", "Stop babysitting…") and most em-dash asides. Word count is down about 10–15% per page.
dsl.md/cli.md: every rule, table, and example is kept. Headings are unchanged so existing#anchorlinks still work (all in-repo anchors checked). The remote-content caveat that appeared twice understate:now appears once. Stale notes are gone: "v0-proven", "v0 examples survive in-tree" (they don't), and "(roadmap)" markers (none exist).index.html,404.html,_config.yml: copy changes only; markup and CSS are untouched.Testing
go build ./...,go vet ./...,go test ./...: passgolangci-lint run(v2.13.2): 0 issuesmake build: linkskubernetes.github.ioand ghcr.io, and nested k3s can't start any pod (even its own coredns fails withfailed to create containerd task). The spec validate /plan --offline/ graph sections passed, and in the ops section every API call against the live cluster (apply, delete, Job create) worked; only the pod-readiness waits failed. The full E2E runs in this PR's CI.Generated by Claude Code