fix: correct typo priviledge → privilege in README.md#669
Open
yosinn1-blip wants to merge 83 commits into
Open
fix: correct typo priviledge → privilege in README.md#669yosinn1-blip wants to merge 83 commits into
yosinn1-blip wants to merge 83 commits into
Conversation
Edited capitalization of some sections to better follow the rest of the readme.
* Update README.md Add minor grammar improvements. * Update README.md Fix grammar.
* chan is leaked * Remove path.Clean Co-authored-by: Andrea Spacca <andrea.spacca@gmail.com>
Co-authored-by: Andrea Spacca <andrea.spacca@gmail.com>
* Implement flake
…utchcoders#422) * issue dutchcoders#420 return 400 response when Max-Days is too big Co-authored-by: kugiyasan <kugiyasan@users.noreply.github.com>
…o big (dutchcoders#422)" (dutchcoders#426) This reverts commit 2959fc2.
* issue dutchcoders#420 return 400 response when Max-Days is too big * issue dutchcoders#420 moved the Max-Days check before saving the metadata * issue dutchcoders#420 added a logging message when Max-Days is invalid * issue dutchcoders#420 added MaxDate.IsZero() check Co-authored-by: kugiyasan <kugiyasan@users.noreply.github.com>
* Add uploading and copy download command
In order to follow golang's best practices, we should lint the code base properly beyond usual syntax mistakes.
This change moves a couple of defers in order to prevent them from not being executed since we have returned in error cases early. It also fixes a couple of smaller linting issues, like error messages not starting with a capital letter and variable name collisions with imported packages.
This change propagates the context of the actual user request through. Additionally it configures the Storj Backend to do in memory buffering instead of relying on temporary files in /tmp/ folders. Fixes dutchcoders#448
* Add X-Url-Delete-* headers to POST handler * Remove token from header * Fix writing of headers * Handle error returned by Write * Update handlers.go Co-authored-by: Andrea Spacca <andrea.spacca@gmail.com>
…hcoders#418) * Docker: use custom non-root UID/GID (build-arg)
In order to prevent viewing content, which max-download rate has been reached, we need to ensure the data is not stored locally in a browser cache. To achieve this, we set the Cache-Control Setting to "no-store" according to: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control fixes dutchcoders#470
…ions (dutchcoders#468) * go.mod,go.sum: Update storj dependencies * bump go version * another bump to latest storj release * set minimum go version in go.mod Co-authored-by: Andrea Spacca <andrea.spacca@gmail.com>
`urfave/cli` v2 was released in 2019, and it doesn't introduce relevant user-facing breaking changes. Migration guide from v1 can be found at: https://cli.urfave.org/migrate-v1-to-v2/ The only user-facing change is within the "Flags before args" section, but I haven't found that to affect `transfer.sh` as arguments are not used. Co-authored-by: Stefan Benten <mail@stefan-benten.de> Co-authored-by: Andrea Spacca <andrea.spacca@gmail.com>
- changing the line `purgeTime = s.purgeDays.String()` to use a function that formats the days like this: "N days" or "1 day" - adding the function `formatDurationDays` in utils.go file Fixes dutchcoders#557 Co-authored-by: Andrea Spacca <andrea.spacca@gmail.com>
Running `go mod download` before copying the entire project to the Docker image avoids dependencies from being re-downloaded every time any file is modified, and `docker build` runs again. This follows the steps detailed in the official Docker guide for Go images: https://docs.docker.com/language/golang/build-images/#create-a-dockerfile-for-the-application Also, `GO111MODULE` doesn't make any difference for the supported Go versions, so it can be removed from the Dockerfile.
* Upgrade aws-sdk-go to v2 `aws-sdk-go-v2` is the newer SDK version, replacing the one being used at the moment by the project. This change maintains full compatibility with existing flags and configurations, and only replaces the underlying library. * Simplify and isolate AWS config logic
* fix basic auth * better logic
…rs#567) Suggestion based on go docs of acme autocert.
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.17.0. - [Commits](golang/net@v0.8.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ioutil has been deprecated since Go 1.16: https://pkg.go.dev/io/ioutil Signed-off-by: ginglis13 <ginglis05@gmail.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.53.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.53.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- use subshell to avoid leaking vars to current shell - use POSIX 'test -t' instead of tty - have a single place to call curl - echo the output url to add the carrier return when needed. - use printf to process \n - silence curl instead of teeing /dev/null Co-authored-by: Andrea Spacca <andrea.spacca@gmail.com>
Add new example with option to upload password protected files of any format Co-authored-by: Alexey Gynu <alexey.gynu@itentika.ru> Co-authored-by: Andrea Spacca <andrea.spacca@gmail.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0. - [Commits](golang/crypto@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.3.3 to 1.3.7. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.3.3...v1.3.7) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Added example script to display URL and deletion token
Use long flags (i.e. --armor) which are easier to understand in examples Co-authored-by: Andrea Spacca <andrea.spacca@gmail.com>
Bumps google.golang.org/protobuf from 1.30.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Generate secure token using crypto rand * Normalize names of uploaded files * revert token.go accidentally added to commit * better input filename normalization using transfrom chain * remove unused line --------- Co-authored-by: Alexey Kostin <a.kostin@corp.mail.ru> Co-authored-by: Andrea Spacca <andrea.spacca@gmail.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0. - [Commits](golang/net@v0.17.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* bump go version and se gotip * bump go version and se gotip * bump go version and se gotip * bump go version and se gotip * linting * gobin * GOPATH
* Docker tag usage * Update README.md * Update README.md * Changed based on feedback * Feedback
…coders#646) I like this project very much, it's great, but there are some errors in readme.md And the following about performance optimization Optimize token generation with strings. Builder Replace inefficient string concatenation with strings. Builder for token generation. This improves performance by reducing memory allocations during string creation. Using WriteByte also avoids unnecessary type conversions from character to string. Co-authored-by: guocheng <cheng.guo@quantix.ae>
Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.3.7 to 1.6.1. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.3.7...v1.6.1) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-version: 1.6.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): replace `dutchcoders/go-virustotal` with `Aetherinox/go-virustotal` replace go dependency `dutchcoders/go-virustotal` with updated package `Aetherinox/go-virustotal` fixes issue with being able to utilize virustotal endpoint when transfering * build(deps): replace `dutchcoders/go-virustotal` with `Aetherinox/go-virustotal` replace go dependency `dutchcoders/go-virustotal` with updated package `Aetherinox/go-virustotal` fixes issue with being able to utilize virustotal endpoint when transfering * docs(readme): add parameter`virustotal-key` to docs * docs(readme): correct auto-formatting on YYYY
* Trim prefix '/' from proxy path * doc: Prefix 'v' in docker image tags * doc(readme): mention trimming of / prefix in proxy path setting
Collaborator
@yosinn1-blip , thanks for the contribution. but please file a PR from a branch with a proper diff with just the small typo fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small typo fix in
README.mdline 272:priviledge→privilege