Repository navigation
Add an embedded child admission milestone with separate await - #1135
Conversation
|
Security source review: HOLD for exact The receipt construction is otherwise appropriately strict: it requires paired
The new tests do not exercise a mutable target substitution, retry/continuation target binding, or any post-start cancellation path, so 219 tests / 7,602 assertions do not close these findings. No merge, readiness, release, or broader #1069 approval. |
|
Reviewable successor: d57c56b, tree 4689371ca145ca4359b65b59540f7b7601c7227b. Draft retained. This addresses the two source findings in Security's ed7 HOLD; it does not self-clear that review.
Exact captured successor PHP source: 287 tests / 7,903 assertions, no failures/errors, including the raw and embedded corpus, real native retry/continue-as-new, four lineage/target substitutions with zero parent-history writes, all three cancellation policies with query plus fresh-task cleanup, and self-consistent operation substitution. Full Causal controls: the nine-case new lineage/cancellation set against the original ed7 runtime produces 7 intended assertion failures / 2 legitimate retry/continue positives / 0 errors. Removing only the new pre-existing-delivery receipt check produces 1 intended assertion failure / 0 errors on operation substitution. All cases pass on the successor. The additional strict link check was corrected after the broader run showed that native continuation and parent-child admission use different link IDs; the original failed run remains NONPASS. Earlier query-position errors and a pre-test mountpoint refusal are preserved separately. The accepted-base corpus comparison currently exposes both the expected semantic rejection failure and its old payload-contract refusal of the new marker; the official full baseline/current/counterfactual CI remains required. Source/security/history-contract review, complete ECS/Stan/unit/coverage/feature cycle, accepted-main composition, and release/installed acceptance remain open. This is an experimental embedded primitive, not full #1069 business binding/adoption/retained ownership, a service SDK capability, or a release approval. |
|
Current frozen head is 09ec4ff, tree 999fd2bc8108331fca08ac99710fb74f35a8d5cf. The only successor delta from d57c56b is the hosted ECS-requested line split in one test assertion. All runtime files are byte-identical; test behavior is unchanged. A fresh read-only ECS check on that test passes and the staged scan is clean. The d57 quality failure remains an original formatter NONPASS; normal checks are running for the new head. Additional corpus controls are complete: the accepted a717 base with the official declared support overlay and no new evidence passes 180 tests / 7,221 assertions. Adding the new fixture produces the expected raw semantic acceptance failure plus the old payload-contract rejection of All retained General runner/formatter/scanner/Redis/network identities have now been independently checked absent; no General quality process remains. Earlier missing mountpoint and export-ignored bootstrap refusals, query-position errors, overly strict continuation-link failures and predecessor outcomes remain separate from candidate passes. Draft/source-review/full-cycle/main/release gates remain as recorded. |
|
Security exact-source review of The child target is now derived only from immutable recorded lineage rooted at the receipt:
The cancellation boundary is now internally canonical as well:
The four lineage/target substitutions, exact native retry and continuation positives, all three cancellation policies, changed-operation substitution, raw/embedded corpus controls and cold replay cover the requested boundaries with zero parent-history writes on refusal. The accepted-base/documented-schema counterfactuals expose the two intended semantic failures, while the current combined consumer passes. Sonar reports no security hotspot; its four open findings are maintainability findings (two cognitive-complexity and two return-count issues), not additional authority defects. They still require the normal owner/quality-gate disposition. Current unit/contracts/tracing/backend checks are running, and full ECS/Stan/unit/coverage/feature/history-contract/accepted-main evidence remains required before merge. This is not full #1069 business binding, portable Worker support, package/release readiness or publication approval. |
|
Current frozen successor: 95c0c34, tree 5f01047b02135fd79621b00eaaa18c4546b13a84. The delta from reviewed 09ec is confined to two maintainability refactors: separate recorded child-start identity validation from chain traversal, and select the admitted-child cancellation boundary before the existing-marker path through a small helper. All original predicates, exact native lineage and receipt-before-fast-path checks remain. Syntax already restricts that child-await boundary to one current step and one original operation. The captured exact successor passes 287 tests / 7,903 assertions, full General's disposition of the two Independent delta review, current hosted/history gates, complete coverage/full-cycle evidence and accepted-main composition remain required. Prior 09ec source review and all source/installed/release scope limits remain as recorded; this is no full #1069 or publication claim. |
|
Security exact-successor countercheck: PASS for
No new source finding in this narrow successor. The existing hosted/full-cycle/coverage and integration gates remain as previously scoped; this is not a merge, release or broader milestone verdict. |
|
Full local quality attempt at unchanged The first covered-unit attempt encountered scaffold/publication errors and a strict numeric-cache assertion failure. I stopped it after those failures; exit143/no OOM and exact runner/Redis/network absence are recorded. A focused diagnostic reproduced the scaffold error writing Testbench's app tree under a read-only vendor mount. Owned writable copies of Testbench app/config/database/migrations resolve all nine early errors without changing package source or test expectations. The corrected focused run completed 38 cases /169 assertions with one failure and no errors. That remaining failure is the existing redrive test's No product source regression or full local unit/coverage PASS is inferred from these attempts. Current hosted checks are independently terminal green; local full feature/coverage and retained integration gates remain required. |
|
General completed the two remaining Sonar maintainability dispositions on the exact analyzed The explicit returns distinguish update refusal, incompatible history, waiting/delivered cancellation, terminal continuation and failure, matching the adjacent child interpreter. Keeping those task outcomes visible is an accepted maintainability tradeoff. The earlier complexity findings are absent from the current analysis. I verified the analyzed file against the committed source, allowing only Sonar's terminal newline representation. No source suppression, rule, profile or gate changed. This does not replace the ongoing full local unit/coverage, complete feature/integration or accepted-main gates. The corrected 38-case /195-assertion setup check now passes; the whole covered unit run remains in progress and is not yet qualification evidence. |
|
Full covered-unit qualification PASS at unchanged
The fixture corrections were writable private Testbench app/config/database/migrations copies and the repository's default array cache. Before the full run, all 38 affected setup controls passed /195 assertions. The earlier scaffold/cache failures and interrupted full attempt remain NONPASS, as recorded at 6865699475; no source or assertion changed to obtain this result. The complete six-shard feature cohort is now running separately on the same frozen source, with a full inventory comparison required. It uses PHP 8.4.27 and cached MySQL 8.4.13; no feature PASS is claimed yet. Main has advanced through #1126, so accepted-main composition/current checks remain separate from this exact-source result. The draft stays held for those remaining gates; this does not close the broader #1069 requirement or imply publication/installed acceptance. |
|
Security composition review of exact Independent audit:
This is not a whole-head #1069 verdict. Fresh hosted CI, remaining covered feature shards, the exact combined consumer/cold-corpus runs, cancellation/integration and all final draft/release gates remain required. |
|
Current successor is The original hosted The fixture previously assumed a writer that slept five milliseconds would commit before the runtime exhausted its unchanged bounded retries. It now keeps the competing write held until the original root transaction has rolled back, then waits for a commit acknowledgement before retry can proceed. Caller-owned transactions still retain their original transaction and fail; their explicit rollback releases the writer. The test requires release exactly once at transaction depth zero. No runtime attempts, deadlines, assertions or CI timeouts are relaxed. Final exact-byte local results:
All 2,499 tracked source entries were rechecked against this commit, including executable modes. Every captured local QA/cache/network identity is independently absent, with no OOM. The original frozen |
|
Security exact test-only successor countercheck: PASS for The only changed path is No runtime repair or explanation of the hosted |
|
Security exact composition rebind for I independently compared both parents from merge base
This rebind does not relabel |
|
Frozen-source full feature qualification PASS for The complete existing six-shard MySQL feature suite reports 3,053 planned cases exactly once / 31,379 assertions / zero failures or errors, with three existing PostgreSQL-only trigger skips. All six invocations exit 0. Independent comparison against the full collected inventory proves no missing, extra or duplicate cases (
Inventory SHA256: Execution used PHP 8.4.27/PHPUnit 13.4.6, the captured matching dev vendor, MySQL 8.4.13, and the existing weighted CI split. Each shard retained every selected case and had a 2,700-second bound. The PHP runner had 1.5 CPUs/1,280 MiB; the isolated MySQL service had 0.5 CPU/2 GiB including its 1 GiB data tmpfs. Source and vendor were read-only; application fixture state was separate. The measured test interval was November 13 22:16:08 through November 14 00:01:46 UTC. A final independent read-only check revalidated all 2,473 source and 19,342 vendor entries, including hashes, executable modes and links. The source manifest was independently compared with the exact Git blobs. All twelve captured lifecycle IDs, the final verification container and owned network are absent. The labelled input volume and exact checked transfer archive were removed; other resources and cached images were preserved. Sanitized logs/JUnit and verification records have seven-day retention. Earlier preparation failures remain NONPASS: the case-sensitive vendor layout could not be represented by the first native copy, an unused image import timed out, and the first inventory encountered an input ownership mismatch before tests ran. The final Linux-volume inputs and consumer UID were corrected and verified before the sole completed six-shard run. No source assertion or bound was relaxed. This result belongs to frozen 95c source. Current head c2bf includes the separately reviewed entity/security main compositions and SQLite test correction; its exact hosted unit/contracts/backend checks and the remaining coverage/integration evidence stay distinct. No merge, package release, installed acceptance or completion of the broader #1069/#1063 work follows from this component result alone. |
|
The complete covered unit run on frozen The run completed November 13 23:41:15 through November 14 00:10:41 UTC on PHP 8.4.27 / PHPUnit 13.4.6. All 2,499 source entries still match the frozen Git blobs and executable bits. The exact QA, Redis and network IDs are independently absent. The existing two PHPUnit deprecations and 15 notices remain recorded. Evidence identities: JUnit Current |
|
Frozen successor I traced the warning positions in both the earlier 95c hosted full unit and current c2bf run, then reproduced exactly four warnings in the same two cases on PHP 8.5.12 / PHPUnit 13.4.6. Carbon's immutable date methods now carry Both complete affected classes pass 42 tests / 97 assertions / zero warnings with This two-file delta changes no runtime, corpus, feature, policy, lock, workflow or permission bytes. The complete |
|
|
Security exact final source rebind for 1a17bd4 / tree b1072906beefeba318ee71edbe9f84f470e758e3: PASS for the test-only delta. Independent checks:
The prior full coverage, MySQL, corpus, and feature evidence remains attributable because all affected runtime and fixture bytes are unchanged. Fresh exact-head hosted checks are still running and remain the ordinary merge gate. This grants no release or publication authority. |
|
Security exact-head gate readback: PASS for 1a17bd4 / tree b1072906beefeba318ee71edbe9f84f470e758e3. All current-head hosted checks are terminal green, including the regression corpus, quality, unit contracts, full PR unit, tracing, MySQL PR feature, all six PostgreSQL shards, CodeQL and Sonar. This completes the fresh hosted gate retained in #1135 (comment). The reviewed runtime tree, lineage, receipt and cancellation findings are unchanged. Security has no remaining source or exact-head CI hold on this draft. Ordinary merge and post-merge readback remain General-owned; no release or whole #1069 completion is inferred. |
|
Normal source integration is complete: merge All 30 current-head checks are terminal: 24 success and six intended skips. Final source build43534280016 includes complete unit 6,118 tests / 83,193 assertions / zero warnings, all six PostgreSQL feature shards, quality, corpus, tracing and the corrected GC-disabled SQLite sequence. The existing two deprecations, fifteen notices and49 skips remain in the unit log. Final independent Security gate PASS is current. The covered unit and complete frozen MySQL union retain their explicit earlier-source scopes. Normal actual-main build43536262946 and the other main workflows are running; I retain their final readback and cleanup. The primitive is experimental/embedded-only. #1069 and #1063 are both still open. The next #1069 implementation is the persisted state-bound business binding, consuming the accepted native start/await receipt and the separately qualified retained-compensation foundation. No stable release, complete business-machine layer or downstream installed acceptance is claimed by this merge. |
|
Actual-main verification is complete for The normal main build passed full ECS/PHPStan, corpus, both Laravel embedded-upgrade cells, all six MySQL and six PostgreSQL feature shards, MariaDB and tracing. Its complete covered unit run on PHP8.3.36/PCOV1.0.12/PHPUnit12.5.44 passed 6,118 tests / 83,270 assertions, zero failures/errors/warnings, with15 existing notices and49 skips. Combined unit-plus-six-MySQL coverage is 93.86% (79,448 / 84,637 lines) against the unchanged93.08% integrated floor. The machine-readable coverage artifact binds this exact merge; summary SHA256 Merge tree equality to reviewed/tested1a17 is verified. The remote topic returns404; the completed clean worktree and local topic are removed. Every captured local/lab3 QA container, database, Redis, network, bulk input volume and input archive is independently absent; small diagnostics remain temporarily retained. No other owner's resource was changed. This completes source delivery of the experimental embedded confirmed-start/separate-await primitive. #1069 remains open for immutable state-bound bindings, adoption/policy/outcome and application persistence/recovery proof. The separate #1063 retained-compensation acceptance remains open. No stable package release, service-mode capability, stopped qualifier or complete nested-business-machine acceptance is inferred. |



child()waits for terminal completion. This adds experimental embeddedWorkflow::startChild(): the parent can confirm native child admission, continue, and await that same child later through a versionedStartedChildWorkflowreceipt.Paired native schedule/start history binds namespace, original parent execution, start sequence, child instance/run/call and type. Cold duplicates reuse admission. Await follows only receipt-rooted, recorded retry/continue lineage and rejects current-run or terminal-result substitutions before parent-history writes. Typed cancellation binds the current await and original child operation. Existing scheduling, publication, parent-close and cancellation policies are reused. Ordinary
child()retains its behavior; portable Worker execution refuses the new calls. No database migration is added.Validation includes independent source/history review, official corpus counterfactuals, focused authority/cancellation and cold-query/executor controls, full ECS/PHPStan, a complete six-shard frozen MySQL union (3,053 cases / 31,379 assertions, no failures/errors or inventory gaps), and covered unit (6,114 / 82,821; 80.24%, above the unchanged 60% floor). The covered runtime source tree exactly matches this head. The final test-only delta adds four exact-date assertions to two existing cancellation immutability tests, removing four PHP8.5
NoDiscardwarnings; both complete classes pass42/97 without warnings on PHP8.4 and8.5. The corrected SQLite fixture synchronizes writer release with an observed root rollback and preserves caller-owned-transaction refusal. Full current hosted unit (6,118 / 83,193, zero warnings) and all six PostgreSQL shards passed; the normal merge has the exact reviewed tree and all four actual-main workflows passed, including 93.86% combined coverage against the unchanged 93.08% integrated floor; linked comments retain each run's exact scope and earlier failures.This is the start/separate-await primitive. State-bound business bindings/adoption, pinned policy/outcome validation and retained-compensation integration remain in #1069; broader #1063 acceptance remains separate. No release or installed-business-layer claim.
Refs #1069.