Skip to content

Settle the pending payload deletion before asserting the bytes are gone (#970) #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmcdaniel merged 1 commit into from
Nov 3, 2026
Merged

Settle the pending payload deletion before asserting the bytes are gone (#970) #997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion tests/Feature/WorkflowStreamPayloadRaceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use App\Models\WorkflowNamespace;
use App\Support\HistoryRetentionEnforcer;
use App\Support\NamespaceExternalPayloadStorage;
use App\Support\RuntimeExternalPayloadDeletions;
use App\Support\RuntimeExternalPayloadException;
use App\Support\RuntimeExternalPayloadObjectLock;
use App\Support\RuntimeExternalPayloadRegistry;
Expand Down Expand Up @@ -598,9 +599,25 @@ private function assertCleanup(string $cleanup, array $result, bool $objectDelet
$this->assertSame($objectDeleted ? 1 : 0, $result['external_payloads_deleted'], json_encode($result));
}

/**
* Cleanup commits the object's last registration together with a durable
* deletion intent; the provider deletion runs after that commit. On
* SQLite the after-commit step can lose the write lock to the writer the
* test has just released (an immediate busy snapshot error) and leave the
* intent for the next cleanup pass (#970). Bytes may outlive the commit
* only with that intent pending, and that pass must remove both.
*/
private function assertObjectDeleted(array $object): void
{
$this->assertFileDoesNotExist(rawurldecode((string) parse_url($object['uri'], PHP_URL_PATH)));
$path = rawurldecode((string) parse_url($object['uri'], PHP_URL_PATH));
$intents = static fn (): int => DB::table('runtime_external_payload_deletions')
->where('storage_uri', $object['uri'])->count();
if (is_file($path)) {
$this->assertSame(1, $intents(), 'surviving bytes need a pending deletion intent');
app(RuntimeExternalPayloadDeletions::class)->retryPending('default', 10);
}
$this->assertFileDoesNotExist($path);
$this->assertSame(0, $intents());
$this->assertSame(0, RuntimeExternalPayload::query()->where('storage_uri', $object['uri'])->count());
}

Expand Down
Loading