Skip to content

Rust #325: re-run the fixtures when their other inputs change #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmcdaniel merged 4 commits into from
Nov 2, 2026
Merged

Rust #325: re-run the fixtures when their other inputs change #923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bac4ba0
Rust #325: re-run the fixtures when their other inputs change
rmcdaniel Nov 1, 2026
a7eeff6
Rust #325: check the PHP capacity bindings path too
rmcdaniel Nov 1, 2026
0956fc8
Merge remote-tracking branch 'origin/main' into rust-325-parity-path-…
rmcdaniel Nov 1, 2026
90add70
Merge main into rust-325-parity-path-gaps (main merge only)
rmcdaniel Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/server-parity.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ on:
- tests/Support/ServerParityAdmissionObservation.mjs
- tests/Support/ServerParityVisibilityObservation.mjs
- rust/**
- tests/Fixtures/ActivityResultInspection/**
- tests/Fixtures/ServerParityReaders/**
- tests/Conformance/ServerParity*.mjs
- benchmarks/capacity/v1/bindings/php/**
- benchmarks/server-port/v2/matched.json
merge_group:
workflow_dispatch:

Expand Down
10 changes: 10 additions & 0 deletions tests/Unit/ServerParityAggregateTest.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,16 @@ test('pull requests run without a path filter and push keeps the one path list',
assert.doesNotMatch(pullRequest, /paths|branches/);
const patterns = pushPathPatterns(workflowText);
assert.ok(patterns.includes('rust/**'));
// Inputs the fixture jobs read outside the server-parity directories.
for (const input of [
'tests/Fixtures/ActivityResultInspection/v1.json',
'tests/Fixtures/ServerParityReaders/sdk-signals.mjs',
'tests/Conformance/ServerParityDeadlinePollTest.mjs',
'benchmarks/capacity/v1/bindings/php/capacity_adapter.php',
'benchmarks/server-port/v2/matched.json',
]) {
assert.deepEqual(matchingFiles(patterns, [input]), [input], `${input} must re-run the fixtures`);
}
assert.ok(patterns.includes('.github/workflows/server-parity.yml'));
assert.ok(patterns.includes('scripts/conformance/server-parity/**'));
});
Expand Down
Loading