Skip to content

Keep completion acceptance polls within its shutdown bound - #257

Merged
rmcdaniel merged 1 commit into
mainfrom
agent/sdk-rust/254-qualifier-poll
Nov 13, 2026
Merged

rmcdaniel merged 1 commit into
mainfrom
agent/sdk-rust/254-qualifier-poll

Conversation

@rmcdaniel

Copy link
Copy Markdown
Member

The completion-limit acceptance fixture waits at most 15 seconds for shutdown but left the Worker's poll timeout at its 30-second default. The first real 3.9.1 run satisfied every normal/over-limit/follow-up assertion, then failed that inconsistent shutdown bound.

Use the existing metrics qualifier's 10 ms poll setting. Keep every workflow, structural-limit, no-partial-activities, follow-up and shutdown assertion unchanged. This changes only the unpackaged public test runner; approved release source afc2b2ff and candidate package 89f6418c stay unchanged. Original run remains NONPASS; confirming exact-tuple acceptance follows this correction.

Validation: formatting/public-boundary checks; fresh archive-only consumer compilation and actual repeat on qualified Server 3.9.1. Refs #254, #256.

@rmcdaniel rmcdaniel added the agent:sdk-rust Owned by the sdk-rust repository agent label Nov 13, 2026
@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel

Copy link
Copy Markdown
Member Author

Security runner-only review: PASS for b3480de83b30764b6d4237f5de243a49d9a22f61 / tree 746a3de965886894c0b68f3b19f3e16b51abdaa9.

The exact delta is confined to tests/completion_limits_server.rs: the acceptance worker now uses a 10 ms long-poll timeout before retaining the existing 16-activity concurrency bound. Business inputs, normal/oversized/follow-up assertions, history checks, zero-partial-activity check and shutdown assertion are unchanged. The setting narrows only this unpackaged runner's idle poll wait so its shutdown can satisfy the existing 15-second test bound; it does not change the frozen afc2b2ff library source or candidate archive 89f6418c....

git diff --check is clean and the focused completion acknowledgement fixture is green. Remaining exact-head CI and the rerun's terminal installed-worker evidence remain required; the earlier final-shutdown timeout stays recorded as NONPASS, and this review does not approve package publication by itself.

@rmcdaniel

Copy link
Copy Markdown
Member Author

Corrected-runner real-worker candidate acceptance PASS, separate from the preserved original shutdown NONPASS.

Exact tuple: SDK package 89f6418ca72e1c6e13495281aab131417c5ddcee1946bfc1a22b1e63cc2b11cc, clean source afc2b2ff8960ac2e080ffec765c66f59200cd544; published native Server 3.9.1 source 7d7ad9d6c9aee2e4592d74389ba9efd36e741f44, index sha256:946c65eb70e8b4b7c4694be8a181c9669d46c3408b80d4e44d96f2030ea3cf51, Linux amd64 child sha256:b0f2bf2a37e8b229282362acb26d9ed511596ebdd366ea4e53bd9f16008a356e. Runner #257 is b3480de83b30764b6d4237f5de243a49d9a22f61, test-file SHA-256 907b5410cffa22110fb852ab9b9f37780d21fa0665328eebc92c3c71364c798b.

The fresh archive-only consumer passed all assertions: explicit advertised ordinary/aggregate limits and no payload store; 300 × 10 KB inline arguments and exactly 300 ActivityCompleted events; a 60 × 450 KB batch yielding one non-retryable structural-limit WorkflowFailed, zero ActivityScheduled and zero ActivityCompleted events; the same worker's subsequent successful workflow; bounded clean shutdown. Test result: 1 passed, 0 failed, 64.75 seconds. Runtime cleanup passed and no owned container remains. Package/runtime bytes are unchanged from the first attempt; only the reviewed runner poll timeout differs.

This is pre-publication candidate evidence. Full package lifecycle/deadline and metrics checks are being bound to this same corrected Server tuple for final package review. Required runner CI, final independent package approval, protected publication, registry identity readback and the exact published-crate feature repeat still gate delivery. #254/shared #228 are not closed by this candidate run.

@rmcdaniel
rmcdaniel marked this pull request as ready for review November 13, 2026 13:00
@rmcdaniel
rmcdaniel merged commit 991daf7 into main Nov 13, 2026
19 checks passed
@rmcdaniel
rmcdaniel deleted the agent/sdk-rust/254-qualifier-poll branch November 13, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:sdk-rust Owned by the sdk-rust repository agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant