Repository navigation
Keep completion acceptance polls within its shutdown bound - #257
Conversation
|
|
Security runner-only review: PASS for The exact delta is confined to
|
|
Corrected-runner real-worker candidate acceptance PASS, separate from the preserved original shutdown NONPASS. Exact tuple: SDK package The fresh archive-only consumer passed all assertions: explicit advertised ordinary/aggregate limits and no payload store; 300 × 10 KB inline arguments and exactly 300 ActivityCompleted events; a 60 × 450 KB batch yielding one non-retryable structural-limit WorkflowFailed, zero ActivityScheduled and zero ActivityCompleted events; the same worker's subsequent successful workflow; bounded clean shutdown. Test result: 1 passed, 0 failed, 64.75 seconds. Runtime cleanup passed and no owned container remains. Package/runtime bytes are unchanged from the first attempt; only the reviewed runner poll timeout differs. This is pre-publication candidate evidence. Full package lifecycle/deadline and metrics checks are being bound to this same corrected Server tuple for final package review. Required runner CI, final independent package approval, protected publication, registry identity readback and the exact published-crate feature repeat still gate delivery. #254/shared #228 are not closed by this candidate run. |



The completion-limit acceptance fixture waits at most 15 seconds for shutdown but left the Worker's poll timeout at its 30-second default. The first real 3.9.1 run satisfied every normal/over-limit/follow-up assertion, then failed that inconsistent shutdown bound.
Use the existing metrics qualifier's 10 ms poll setting. Keep every workflow, structural-limit, no-partial-activities, follow-up and shutdown assertion unchanged. This changes only the unpackaged public test runner; approved release source
afc2b2ffand candidate package89f6418cstay unchanged. Original run remains NONPASS; confirming exact-tuple acceptance follows this correction.Validation: formatting/public-boundary checks; fresh archive-only consumer compilation and actual repeat on qualified Server 3.9.1. Refs #254, #256.