Skip to content

Isolate the optimization guard control from runner startup state #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmcdaniel merged 1 commit into from
Nov 5, 2026
Merged

Isolate the optimization guard control from runner startup state #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions scripts/acceptance/condition-history/test_packet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,17 @@ def test_preflight_refusals_precede_any_side_effect(self):
self.assertFalse(pathlib.Path(args.work_dir).exists())

def test_wrong_h_refuses_under_python_optimization(self):
result = subprocess.run([sys.executable,str(HERE/'run.py'),'run','--checkout',str(REPO),
'--runner-commit','a'*40,'--package-commit','b'*40], env=dict(os.environ,PYTHONOPTIMIZE='1'),
capture_output=True,text=True,timeout=5)
startup = self.root / 'ambient-startup';startup.mkdir()
(startup / 'sitecustomize.py').write_text("raise SystemExit('unexpected ambient startup')\n")
env = dict(os.environ, PYTHONPATH=str(startup), PYTHONOPTIMIZE='1')
argv = [str(HERE/'run.py'),'run','--checkout',str(REPO),
'--runner-commit','a'*40,'--package-commit','b'*40]
ambient = subprocess.run([sys.executable, *argv], env=env,
capture_output=True, text=True, timeout=20)
self.assertNotEqual(ambient.returncode, 0)
self.assertIn('unexpected ambient startup', ambient.stderr)
result = subprocess.run([sys.executable,'-I','-S','-B','-O', *argv], env=env,
capture_output=True,text=True,timeout=20)
self.assertNotEqual(result.returncode,0)
self.assertIn('wrong fixed package source',result.stderr)
self.assertFalse(pathlib.Path(self.args.work_dir).exists())
Expand Down
Loading