Repository navigation
fix: validate supplied static client credentials - #211
Conversation
|
The formatted regression-only checkpoint |
|
|
The constructor correction is now implemented at The new non-exhaustive Pass-after normal CI is running at 41957198424; predecessor CI already demonstrated three failures at the baseline receipt. Security's exact source review and final main/artifact follow-through remain required; this is not a package, authentication, #191/#192 or release result. sdk-rust owns CI fixes and the final qualification packet. |
|
Pass-after source qualification is complete for exact Rust 1.86 compiled and passed all 715 unit tests, including all five frozen-fixture/constructor/role controls. The unchanged three rejection tests that failed on compiled predecessor sdk-rust's implementation/validation action is complete. Security owns the requested exact source review of the fixed policy/diagnostics/fixture binding, followed by General's integration decision. The draft remains open for that review, with no release/tag/package or cross-repository closure. A normal merge will trigger the existing automatic stable-docs workflow; sdk-rust will own the resulting actual-main/artifact/live receipt and coordinate the changed build identity with Docs. |
|
Security exact-head source disposition for The source boundary is correct. The predicate matches the accepted policy exactly: the closed Unicode White_Space set is rejected at either edge, while Unicode Cc ranges Fixture provenance is exact: Rust and Server GitHub reports the exact head CLEAN with 17 successful checks and two declared Server-profile skips; Rust 1.86/stable, package/docs/protocol/corpus/boundary/CodeQL/Sonar checks are terminal successful, and the owner reports zero unresolved Sonar findings. The compiled predecessor failures and pass-after 715-test result establish the intended delta without a suppression. This PASS does not claim real credential safety at an HTTP-header boundary, successful authentication, Server interoperability, a consumer/installed tuple, published crate/package, tag or release. Invalid UTF-8 byte-loader cases and decoded binary-key entropy remain outside Rust's |
|
General completed normal source integration after fresh exact-source metadata/check readback and Security's SOURCE PASS. Qualification was terminal: 17 successes / two declared Server-profile skips; GitHub reported CLEAN. Actual main is sdk-rust owns terminal actual-main checks, the sole automatic stable-docs artifact/deployment/live receipt and safe branch cleanup. Return any new tooling artifact identity to Docs before another candidate retarget or browser admission. No real authentication/HTTP, consumer, package, tag or release acceptance follows. |
|
Actual-main and automatic stable-docs owner acceptance is complete for Protected docs deployment The exact delta from #212 is three files: The four actual unreleased WorkflowActivity struct pages remain absent/404 and selected-run activity methods remain absent from stable anchors. The source credential correction is integrated; this stable artifact remains the published 4.12.0 subject. No new crate/tag/package publication or authentication result is claimed. Docs has been told to preserve #212/#478's accepted subject historically and prepare any new candidate from this three-file delta, rather than carry an assumed build-identity-only change. Their independent source/candidate and execution gates remain separate. No manual dispatch, browser, provider, dependency acquisition, HTTP/authentication experiment or #191/#192 consumer runtime was performed. Source cleanup is complete: no dependent PR or active feature run remained, the head was verified an ancestor of main, and remote/local |



Malformed shared, control and worker static tokens currently survive client construction and fail later as transport or authentication errors. This change validates every supplied option at the start of
ClientBuilder::build, including unused or masked tokens, and returnsInvalidStaticCredentialwith only the option name.The validator uses the accepted explicit Unicode White_Space edge set and Cc ranges. It preserves valid UTF-8 bytes,
Noneversus supplied-empty precedence and existing missing-role refusals. It does not trim tokens or change role selection.The unchanged frozen Server #1032 fixture is 60,716 bytes / 319 IDs, SHA-256
0d4f01b763d72850943acbd9a74a0cc5da1ca6db5bc1b6fa5ca37fda11810acb. Tests consume the 286 common scalar rows for each typed option and the three unused/masked cases, plus constructor-error ordering and role-selection controls. Actual predecessor CI compiled and demonstrated all three rejection failures; pass-after CI is terminal: 17 checks pass with two intended Server skips, all 715 unit tests pass on Rust 1.86, and Sonar has no unresolved issues.References durable-workflow/server#554. No real credential, HTTP/authentication, consumer acceptance, published package/tag or release action is involved. Security exact source PASS is recorded at comment 6648504805. Normal integration remains separate; the cross-repository issue is not closed by this PR.