Repository navigation
Acknowledge pending replay without rejected empty completions - #99
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Use the established
WorkflowTaskWaitingForHistoryacknowledgement when replay has no new commands. Preserve the original task, lease owner, attempt and worker credential. Nonempty completion commands retain their wire contract. Refuse message-stream metadata without commands before a waiting request, preserving progress.Delivered
Merged as
2fe5acc9f03664bd5fff5d298849931477247d81and published as 2.4.2. Exact PR/main CI succeeds with 2,460 unit tests across Python 3.10/3.11/3.12 and 22 connected tests. Lint, mypy, regression corpus, package/smoke, docs, boundary, target-branch and publication gates pass. Five added regression cases reproduce the baseline failure.The installed PyPI package passes published Server 2.3.12 to 2.5.6 recovery with PHP 2.2.3 and Rust 3.2.0. All nine original runs preserve external payloads and committed history prefixes. Waiting runs preserve one timer through repeated signals and process SIGKILL before its original deadline. Normal supervisors recover workers, and each run completes once. Full transport logs show zero HTTP 422s and six waiting acknowledgements. Python logs have no task completion error.
The live reference is verified, the merged remote branch is deleted and all disposable test resources are removed. Owning issue: #98.