Repository navigation
Keep admitted Nexus calls pending during cold replay - #128
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
An admitted, completion-waiting Nexus call remains pending at its original yield. Cold replay now validates the recorded operation and submits no new
start_service_operationcommand.The published Python 2.6.0rc2 baseline in Server #425 appended 64, 63, 68 and 70
ServiceCallStartedevents for one original call per cancellation case. Targets were started once. This fixes the replay readmission path responsible for the growing history.Existing terminal delivery, async/acceptance-only calls, external results, changed-target rejection and legacy SideEffectRecorded replay retain their tests. Adds an immutable pending cancellation replay fixture.
Verification
This is one correction toward #116 and Workflow #753. It does not advertise Nexus cooperative cancellation or qualify a published replacement package. The accepted cancellation request regression intentionally requires no delivery until the separate capability-gated correction exists.
Related: durable-workflow/workflow#753