Repository navigation
Identify worker startup timeout before task polling - #126
Merged
Merged
Conversation
rmcdaniel
marked this pull request as ready for review
October 12, 2026 05:54
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the workflow wait budget expires during Server discovery or registration,
run_until()reports only that the workflow has not reached a terminal state. A published delayed-reply experiment in #123 demonstrates registration can commit while the SDK still waits for its reply and has not begun polling.Change
Identify startup timeouts with the worker, workflow and existing wait budget. Preserve the generic workflow timeout after startup, the original exception cause, the same deadline and current cleanup authority. Document how startup, drain and replacement work fit together.
Two executing regressions cover held discovery and held registration. The existing post-startup timeout remains a control. The deliberate real Server experiment preserves the original 30-second budget and proves a replacement can finish the same original run once.
Scope and delivery
This improves diagnostics. It does not identify why the original unconstrained registration reply was delayed, and #123 remains open. Main contains an unqualified Nexus producer candidate, so stable delivery must use a narrow backport from the published stable line.
Focused tests and Ruff pass. Normal source checks are next, followed by the stable backport and affected published-package verification. No Server wire or worker-incarnation contract changes.
Related to #123.