Repository navigation
Reject ambiguous registrations before polling - #110
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Reject duplicate workflow and activity wire names in the production Worker before contacting Server. Reject conflicting signal, query, update and validator names at class decoration.
DuplicateRegistrationErroris a public SDK error with the kind, wire name and both definitions.Python method resolution stays explicit: overriding the same attribute is valid, while different resolved attributes cannot claim the same name within one handler kind. Worker, Replayer and test-environment admission independently apply the same resolved-handler validation, including programmatically defined classes. Names are scoped to each Worker/Replayer and each handler kind. The workflow test environment rejects replacement by a different class and keeps same-class registration idempotent for automatic execution. Explicit activity mock setters still allow replacement.
Refs #105. Prepares routine SDK 2.5.4 with unchanged wire protocol and supported Server floor. Publication and issue closure follow exact main, registry and ordinary consumer qualification.
Verification