Skip to content

Reject unsupported asynchronous workflow definitions and results - #108

Merged
rmcdaniel merged 4 commits into
mainfrom
fix/106-workflow-entrypoint
Oct 10, 2026
Merged

rmcdaniel merged 4 commits into
mainfrom
fix/106-workflow-entrypoint

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

What changed

Reject coroutine and async-generator workflow entry points during definition and production worker registration, before contacting Server. Share validation with the public test environment and direct replay, including wrapped and inherited methods.

Prevent a synchronous or generator workflow from completing with an awaitable result. Surface the typed InvalidWorkflowDefinition SDK error and close native coroutine results instead of leaving them unawaited. Supported synchronous/generator workflows and async activities retain their execution models.

Verification

  • Ten focused regressions fail against published-source 2.5.1; the valid workflow control passes.
  • All 51 focused definition and replay-corpus checks pass with the correction.
  • Add one official replay fixture for the previously accepted async entry point.
  • Ruff, mypy, the full suite and official counterfactual qualification are required before merge. Published-consumer verification is required before closing Reject unsupported async workflow definitions before polling #106.

Related to #106. No SDK release has been published for this change.

Prepare the patch artifact as 2.5.2. Final focused checks pass 57 tests, including callable objects and partial async functions; Ruff and mypy pass. The local full run passes 2,544 tests with two Git-dependent tooling checks blocked by the minimal container. Hosted full suites are required and include Git. The official fixture uses the existing error-only outcome format.

@rmcdaniel
rmcdaniel marked this pull request as ready for review October 10, 2026 19:12
@rmcdaniel
rmcdaniel merged commit 39ae905 into main Oct 10, 2026
13 checks passed
@rmcdaniel
rmcdaniel deleted the fix/106-workflow-entrypoint branch October 10, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants