Repository navigation
Reject unsupported asynchronous workflow definitions and results - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Reject coroutine and async-generator workflow entry points during definition and production worker registration, before contacting Server. Share validation with the public test environment and direct replay, including wrapped and inherited methods.
Prevent a synchronous or generator workflow from completing with an awaitable result. Surface the typed
InvalidWorkflowDefinitionSDK error and close native coroutine results instead of leaving them unawaited. Supported synchronous/generator workflows and async activities retain their execution models.Verification
Related to #106. No SDK release has been published for this change.
Prepare the patch artifact as 2.5.2. Final focused checks pass 57 tests, including callable objects and partial async functions; Ruff and mypy pass. The local full run passes 2,544 tests with two Git-dependent tooling checks blocked by the minimal container. Hosted full suites are required and include Git. The official fixture uses the existing error-only outcome format.