Skip to content

Skip redundant APT browser dependencies in source CI #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmcdaniel merged 7 commits into from
Nov 6, 2026
Merged

Skip redundant APT browser dependencies in source CI #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
294cd5f
Reuse runner Chrome for documentation source checks
rmcdaniel Nov 5, 2026
17d8cbf
Merge remote-tracking branch 'origin/main' into fix/315-installed-bro…
rmcdaniel Nov 5, 2026
373bca7
Record runner browser facts before prerequisite refusal
rmcdaniel Nov 5, 2026
383ed06
Merge remote-tracking branch 'origin/main' into fix/315-installed-bro…
rmcdaniel Nov 6, 2026
c1eccb1
Keep locked Chromium source checks without APT dependency installation
rmcdaniel Nov 6, 2026
d171d6b
Limit bundled-browser acquisition change to source CI
rmcdaniel Nov 6, 2026
83902bd
Merge remote-tracking branch 'origin/main' into fix/315-installed-bro…
rmcdaniel Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ jobs:
--root-dir build/site
build/site
- name: Install the locked Chromium browser
run: '"$DOCS_TOOLING_DIRECTORY/node_modules/.bin/playwright" install --with-deps chromium'
run: '"$DOCS_TOOLING_DIRECTORY/node_modules/.bin/playwright" install chromium'
- name: Verify missing-resource browser evidence
run: npm --prefix "$DOCS_TOOLING_DIRECTORY" run test:docs-browser-failures
- name: Check portal and API layouts in Chromium
Expand Down
1 change: 1 addition & 0 deletions scripts/check-docs-browser.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ try {
};
if (process.env.PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH) launchOptions.executablePath = process.env.PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH;
browser = await chromium.launch(launchOptions);
console.log(`Launched browser version: ${browser.version()}`);

const surfaces = [
{name: 'home', path: '/', kind: 'portal'},
Expand Down
Loading