Repository navigation
Adopt Workflow 2.5.0 in embedded examples - #146
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Adopt published Workflow 2.5.0 in the Laravel application and microservice lockfiles. Update their artifact tuple to match. Each Composer update changes only the Workflow package.
This completes the embedded example follow-through for durable-workflow/workflow#627 and its supported PHP schedule timeouts. Server remains at 2.5.6 because its remote schedule starter already forwards both timeout fields. SDK versions and Waterline's runtime package are unchanged.
Verification
Workflow's complete source build passed at c002f44b14a9284efd73ebaf5060f1c0bbb1c5ad. A separate consumer installed from Packagist passes 18 persisted-run cases with 86 assertions, including manual and automatic starts, updates, omitted values and validation. Both committed lockfiles resolve that exact source without other dependency changes or advisory findings.
All exact-head PR and main Sample App, Compose and polyglot checks pass. Merged at c8b4e27. All six publication jobs pass, including both actual published-image architectures: https://github.com/durable-workflow/sample-app/actions/runs/37558391417. The immutable image and both public main channels resolve index sha256:f87e8ac63175792e3d726e83de08e9befc926b5dcff8ca2afd7a45c7f596248a. The published Workflow Laravel/PHP matrix passed all 16 cells in 37557667193.