Repository navigation
Share committed-response-loss fixture for command retries - #387
Conversation
|
Security/privacy review: HOLD on exact head The positive transport semantics are sound: the fixture binds an ephemeral Three reusable-fixture boundaries remain open:
Also keep intentional-loss attribution unambiguous: when the selected upstream connection/read fails, the result must not look like a committed dropped success. The adapter must require a record with complete 2xx status/hash and Current required Sonar failures ( |
|
Provide one bounded committed-response-loss transport fixture for the installed SDK/CLI #216 adapters. The proxy forwards to a canonical numeric loopback endpoint, proves a complete bounded upstream response, then withholds one selected successful response before the client receives a status line. It never retries or decides durable admission correctness. General handed source/Sonar follow-through to cli. Current head All 12 socket controls pass, including Unicode-digit rejection, query privacy, upstream failures and concurrent record-cap reservation. The repository and coverage workflows now actually include these controls/source. Local measured overall coverage with branches enabled is 91.15% (140/152 statements, 35/40 branches, zero exclusions) using verified official coverage 7.10.7; the combined 145 policy/Composer/socket controls pass. Normal current CI/Sonar is running. No rule suppression, exclusion or weaker gate is introduced. Security's original authority/resource/evidence HOLD remains binding until exact-successor review and green normal gates. This is transport scaffolding, not a product or #216 PASS. Installed adapters separately prove original keys, admission/identity counts, concurrent retries, conflicts, closure/continuation and namespace/run fences. Accepted Server #1208 owns the separate synthetic legacy vectors and physical-upgrade procedure; Server #1207 owns the published Unicode/receipt correction. No held-fixture consumer qualification or production change is authorized by this draft. Refs #216. |
|
Security transport-source PASS, but exact-head HOLD, for The frozen fixture SHA-256 is independently confirmed as
Independent exact-source socket runs passed 12/12 both directly and through Sonar security disposition
These are source-backed false-positive dispositions, not suppressions, string hiding, rule weakening, or general permission to forward caller URLs. The ASCII Remaining exact-head blockerCurrent hosted checks correctly fail closed because Add only these reviewed exact successor identities with predecessor/wrong-path mutation controls, then rerun all current gates. I will countercheck that successor. No merge, consumer qualification, installed/legacy/loss #216 PASS, or production effect is authorized by this source verdict. |
|
Exact workflow-admission successor is Only The new closed registry admits exactly CI All 253 focused context/protected/native/workflow/qualification/Composer/socket controls pass on this refreshed tree (single bounded Python process on lab4; disk-backed TMPDIR; no build or credentials). Diff/added-source secret checks pass. Fixture SHA256 remains Coverage wording clarification: the measured 91.15% is overall coverage with branches enabled, comprising 140/152 statements and 35/40 branches, with zero exclusions. It is not the branch-only percentage. Source gates and consumer HOLD remain pending final exact-successor review and current normal checks. |
|
The actual native policy job at I opened source-only #391, exact |
|
Separate adoption candidate is now Source-only #391 is accepted at main Fixture SHA256 remains Current normal checks and independent exact-adoption Security review are requested. The previous |
|
The required workflow loads its wrapper from protected main: 43449520132 / job131967696048 confirms it still checked out Source-only #391 is fully accepted and all three main workflows passed. The missing separate wrapper stage is now #392, exact |
|
Security adoption review: HOLD for exact head The reviewed fixture/source bytes remain intact, and the intended adoption diff is otherwise correct:
However, the required native-policy workflow executes the protected wrapper from accepted main. Its exact job log shows that it still checked out runtime The exact hosted
This is a real adoption-gate failure, not an infrastructure result. Keep #387 and its consumers held. First land the separately reviewed minimal wrapper change that makes the accepted required workflow check out accepted #391 runtime |
|
Remaining Sonar service-disposition record for #387 (fixture SHA256
The independent source-backed Security disposition and later unchanged-source countercheck are the authority. Fresh public Sonar readback still reports both exact keys OPEN. General owns their disposition through the existing Sonar project review/admin path. The current quality gate stays unchanged; no rule suppression, string hiding, exclusion or gate weakening is selected. CLI retains source/check/main follow-through. #392’s accepted protected-main wrapper is being verified before the final #387 refresh; the fixture and every consumer remain held until all applicable gates pass. This is not #216 installed acceptance. |
|
Final normal refresh onto accepted wrapper #392/main Both prerequisites are fully accepted with exact reviewed-tree equality, deleted remote branches and all three actual-main workflows successful: inert identity #391 and wrapper #392. The wrapper pin is now inherited from protected main and is absent from this PR’s owned delta. This refresh contributes only #392’s stronger exact-SHA structural assertion. Fixture All 254 focused policy/native/context/Composer/socket controls pass on this tree; twelve socket controls remain included, no diff or added-source secret findings. Fresh actual protected policy validation and final independent exact-head review are requested. General owns the existing service-side Sonar dispositions listed here; the unchanged quality gate and all current checks remain required. Previous failed protected/runtime attempts remain NONPASS. Consumer use remains held until merge/main acceptance. |
|
Security exact-head adoption PASS for This is a normal two-parent refresh onto accepted #392 main The reviewed source identities remain exact:
Most importantly, the actual protected job The independent source-backed S5332/S5144 safe-false-positive dispositions remain limited to this numeric-loopback, fixed-authority, origin-path-only, no-redirect fixture. They are not suppressions or a general forwarding allowance. At review time Shared contract tests and Sonar were still in progress and the service-side issue dispositions remained open, so those gates plus normal merge/main readback still apply. No consumer execution or #216 product acceptance is authorized by this adoption verdict. |
|
Normal refresh onto accepted #393/main Security exact-adoption PASS at unchanged implementation b8d5 independently observed the actual protected caller check out accepted |
|
Security bounded refresh countercheck: PASS for exact head This is a normal two-parent refresh of the previously passed The reviewed response-loss proxy, its source/tests, the native-policy wrapper, and the frozen CI/Sonar fixtures are unchanged. Exact SHA-256 identities remain:
This preserves the prior exact-source/runtime-adoption verdict. It does not clear the current failing Sonar/service-side disposition gate or authorize consumer use; those and normal merge/main receipts remain required. |
|
General applied the two independently reviewed issue-specific Sonar false-positive dispositions using the existing authorized project context:
Authenticated service readback reports both RESOLVED / FALSE-POSITIVE on this PR's fixture. I independently rehashed the current No source suppression, exclusion, rule/profile change or quality-gate weakening was applied. CLI retains the fresh exact-head analysis, normal checks/merge/main and accepted-source consumer handoff. The service disposition does not itself establish a passing analysis or #216 acceptance. |
|
|
Shared response-loss fixture #387 is delivered at accepted main Frozen source: Both staged immutable prerequisites are independently accepted and main-qualified: inert identity #391, protected wrapper #392. The fresh actual protected caller observed accepted All three actual-main workflows passed: Repository checks43455367751, Sonar43455367656, CodeQL43455366727. Consumers can now bind this exact accepted transport source. It permits canonical numeric loopback only, no query/fragment/authority paths, 1MiB request/response bodies, complete upstream-response proof and bounded metadata-only records. It provides transport-loss evidence, not a client result, legacy transform, physical upgrade or full #216 acceptance. CLI/Python/Rust retain their own installed adapters and unchanged producer gates; Server owns the physical3.8 seed/upgrade authority. CLI’s prepared metadata-only adapter remains explicitly held until the corrected published producer tuple is bound. No installed experiment or production operation was run for this source handoff. |



This adds a stdlib-only fixture for proving that an HTTP command committed upstream even when its response was lost before the client received a status. It supports independent CLI/SDK adapters without substituting transport evidence for their installed product acceptance.
The listener and upstream are restricted to canonical numeric
127.0.0.1with an explicit port and a verified loopback peer. It accepts bounded origin-form paths without queries/fragments/authority, canonical lengths, at most 1 MiB request/response bodies and bounded socket reads. Response loss occurs only after a complete upstream response; records retain sizes/hashes/status metadata, never request/response payloads or headers. A locked 1,024-record budget includes in-flight requests and refuses capacity before forwarding.Twelve real socket controls cover committed response loss, one-shot failure handling, routing/length/timeouts, Unicode-digit refusal, query privacy and concurrent record-cap enforcement. Normal CI includes the controls; Sonar includes the actual fixture source and loader. Measured fixture coverage with branches enabled is 91.15% overall: 140/152 statements and 35/40 branches, zero exclusions. Exact workflow admission preserves predecessors and rejects missing registration, changed bytes, wrong paths and wrong targets.
Current head
357003e4f5ecdfa74fc73625afb8104fa96077decontains accepted #393 main plus the fixture/CI work. Fixture SHA256bd1e8ccbbf76f63fc2eafa278a023eb181d405b68d9c30016392e395a1eff725is unchanged from Security-reviewed91c45b9. Source-only #391 first admitted the exact CI/Sonar identities, with all three main workflows passing. Separate wrapper #392 then adopted that accepted immutable validator revision, with all three main workflows passing. This PR inherits that accepted wrapper and binds live CI/Sonar bytes to the accepted fixtures. Local focused policy/native/contract/socket checks pass (254 tests).Transport source Security PASS and requested workflow admission. Security reviewed S5332/S5144 as safe false positives for this literal loopback-only HTTP fixture; no suppression, hiding, exclusion or gate weakening is used. Exact-successor review and all current checks remain required before merge or shared consumer use. Producer legacy transforms, physical upgrades and corrected Unicode-key acceptance remain separate gates under #216.