Conversation
…space Refactor the cron scheduling pieces so the parser and timing live in Sa.Schedule.Cron instead of Sa.Schedule.Engine: - Move CronTiming from Engine to Cron/, splitting field parsing into CronFieldParser + CronField, and adding a dedicated CronParseException. - Simplify IJobTiming.GetNextOccurrence to a single argument (drop the unused IJobContext parameter); update JobController, tests accordingly. - Add WithCron on JobProperties and a CronTimingAdapter bridge so the builder wiring keeps working against IJobTiming. - Drop the now-redundant Engine.JobTiming, add Settings.JobTiming. - Add detailed EN/RU cron docs under Cron/ and link them from the READMEs. - Update tests: single-arg calls, empty-expression throws CronParseException, and relaxed invalid-range assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the cron scheduling pieces so the parser and timing live in Sa.Schedule.Cron instead of Sa.Schedule.Engine: