Skip to content

fix: wrong vanished parsing#706

Merged
duesee merged 2 commits into
duesee:mainfrom
soywod:main
Jun 3, 2026
Merged

fix: wrong vanished parsing#706
duesee merged 2 commits into
duesee:mainfrom
soywod:main

Conversation

@soywod
Copy link
Copy Markdown
Contributor

@soywod soywod commented May 29, 2026

Fixes #705

Comment thread imap-codec/src/response.rs
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 29, 2026

Coverage Report for CI Build 26912546095

Coverage increased (+0.1%) to 91.358%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: 52 of 52 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11594
Covered Lines: 10592
Line Coverage: 91.36%
Coverage Strength: 917.01 hits per line

💛 - Coveralls

@soywod
Copy link
Copy Markdown
Contributor Author

soywod commented May 29, 2026

Audit failure seems not related to this PR.

@duesee
Copy link
Copy Markdown
Owner

duesee commented May 31, 2026

Thanks! I can take a look tomorrow evening and will also fix the audit, don't worry about it. In the meantime... could you add a few "known answer tests", i.e., copy some examples from the RFC and try to parse them? Would help me greatly to see what is going on :-)

Should we make a release after merge?

@soywod
Copy link
Copy Markdown
Contributor Author

soywod commented May 31, 2026

Done!

Copy link
Copy Markdown
Owner

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I'll try to fix the CI and get this in :-)

@soywod
Copy link
Copy Markdown
Contributor Author

soywod commented Jun 2, 2026

Awesome, thanks a lot. Let me know when a release is out so I can push mine :)

@duesee
Copy link
Copy Markdown
Owner

duesee commented Jun 2, 2026

Will do! Wanted to do yesterday... but... life :-) I'll br on a long train ride tomorrow or the day after. Will try to do quickly. Only have a smartphone at hand right now :-)

@duesee duesee enabled auto-merge (rebase) June 3, 2026 20:58
@duesee duesee merged commit b5a1100 into duesee:main Jun 3, 2026
10 checks passed
@duesee
Copy link
Copy Markdown
Owner

duesee commented Jun 3, 2026

Tada :-) https://crates.io/crates/imap-codec/2.0.0-alpha.8

@soywod
Copy link
Copy Markdown
Contributor Author

soywod commented Jun 3, 2026

I was monitoring my mails, waiting for the news :D thank you. I'm releasing io-imap finally, let you know when out!

@soywod
Copy link
Copy Markdown
Contributor Author

soywod commented Jun 3, 2026

Tada :D https://docs.rs/io-imap/latest/io_imap/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong parser for VANISHED

3 participants