Rename the Duck.ai menu's Chats entry and menu to NTP - #9765
Open
malmstein wants to merge 3 commits into
Open
Conversation
Ship review asked for the entry to read Chats rather than All Chats, so point it at duck_ai_chat_history_title, the already translated title of the screen it opens, and drop the untranslated string it replaces. Ask About Page now hides itself when the tab has no page, which is what leaves New Chat and Chats when the menu is shown from the NTP. https://app.asana.com/1/137249556945/project/1174433894299346/task/1218339917320990 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The menu was suppressed on the NTP because contextual chat is about the page you are viewing. Now that it carries a Chats entry alongside New Chat it earns its place there, so offer it when that entry is enabled and the query is empty, and keep opening Duck.ai directly otherwise. The NTP omnibar is focused from the start, so the menu hangs off an empty query there rather than off focus as it does on a page. https://app.asana.com/1/137249556945/project/1174433894299346/task/1218339917320990 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
In search-only mode the new tab page shows the native input field, whose start chat icon submitted straight to Duck.ai. An empty input has nothing to send, so it now opens the same menu the omnibar shows, New Chat and Chats. Anything typed still goes straight to Duck.ai, as does an empty input when the menu entry is disabled. The host gains isInputEmpty and tabId so the plugin can make that call and hand the tab to the existing contextual menu. https://app.asana.com/1/137249556945/project/1174433894299346/task/1218339917320990 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
malmstein
changed the title
malmstein
marked this pull request as ready for review
September 9, 2026 22:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1174433894299346/task/1218339917320990
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable): None
Description
Brings the Duck.ai menu to the new tab page and relabels its third entry from All Chats to Chats. The NTP has two different Duck.ai affordances depending on the address bar setting, the omnibar icon and the native input's start-chat icon, so both now open the menu when the input is empty and
contextualMenuAllChatsis on; typed input still goes straight to Duck.ai, as does an empty input with the flag off. The rename reusesduck_ai_chat_history_title, already translated in all 24 locales, so no new string is introduced. Pixels are unchanged.Steps to test this PR
NTP, address bar set to "Toggle between Search and Duck.ai"
NTP, address bar set to "Search Only"
Page menu unchanged
Flag off
contextualMenuAllChatsoff in Feature Flag Inventory, force stop and relaunchNote
Low Risk
Feature-flagged Duck.ai entry-point and menu UX only; behavior on loaded pages is unchanged aside from the Chats label string.
Overview
Extends the Duck.ai contextual menu (New Chat + Chats, relabeled from “All Chats” via
duck_ai_chat_history_title) to the new tab page whencontextualMenuAllChatsis on and the omnibar query is empty.Omnibar: NTP no longer always skips contextual mode—empty query + flag opens
ShowDuckAIContextualMode; typed query or flag off still opens full Duck.ai. Regular pages keep unfocused-only contextual behavior.Native input start-chat icon: Empty input + flag shows the same menu through
DuckChatContextual.launchwithsourceUrl = null; non-empty input still callssubmit().NativeInputHostgainsisInputEmpty()andtabId()for that routing.Menu content:
RealDuckChatContextualpassessourceUrlintoshowMenuand hides Ask About Page when there is no page (NTP/blank tab).Reviewed by Cursor Bugbot for commit 75fb6a8. Bugbot is set up for automated code reviews on this repo. Configure here.