Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 9, 2026
joshliebe
force-pushed
the
feature/josh/ask-duck-ai
branch
from
September 10, 2026 14:55
99f7022 to
3e194f5
Compare
joshliebe
force-pushed
the
feature/josh/ask-duck-ai-l10n
branch
from
September 10, 2026 14:56
b17cabb to
a2565cf
Compare
# Conflicts: # duckchat/duckchat-impl/src/main/res/values/donottranslate.xml
Translate strings-desktop-app-promotion to values-sv Translate strings-desktop-app-promotion to values-it Translate strings-desktop-app-promotion to values-ru Translate strings-desktop-app-promotion to values-hu Translate strings-desktop-app-promotion to values-sk Translate strings-desktop-app-promotion to values-pt Translate strings-desktop-app-promotion to values-hr Translate strings-desktop-app-promotion to values-lt Translate strings-desktop-app-promotion to values-et Translate strings-desktop-app-promotion to values-cs Translate strings-desktop-app-promotion to values-fi Translate strings-desktop-app-promotion to values-tr Translate strings-desktop-app-promotion to values-fr Translate strings-desktop-app-promotion to values-es
Translate strings-duckchat to values-it
added 5 commits
September 17, 2026 17:20
joshliebe
force-pushed
the
feature/josh/ask-duck-ai
branch
from
September 17, 2026 21:21
3e194f5 to
3c6a38e
Compare
joshliebe
force-pushed
the
feature/josh/ask-duck-ai-l10n
branch
from
September 17, 2026 21:21
e9a50a8 to
e8e467e
Compare
Translate strings-sync to values-hr
Translate strings-sync to values-nl
Translate strings-sync to values-ro
karlenDimla
approved these changes
Sep 19, 2026
karlenDimla
left a comment
karlenDimla
left a comment
Contributor
There was a problem hiding this comment.
Looks OK. Note a few sync related strings added in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1200204095367872/task/1218319678030439?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Steps to test this PR
Note
Low Risk
String-resource and translation-only changes; no logic changes, though a few updated locale strings (e.g. hr) may need a quick copy review.
Overview
Localizes Duck.ai “Ask from text selection” copy that previously lived only in
donottranslate.xml. Those strings now sit in defaultstrings-duckchat.xmland are translated across all supported locales (selection menu label, summarize/translate suggestion chips, attachment title, selection limit message, and word-count plurals).Desktop browser promotion strings get the same Smartling treatment in every locale: UTF-8 header,
instructionattributes on toolbar title / download URL / “link copied”, plus minor wording fixes in a few languages (e.g. Russian body copy, Lithuanian/Latvian titles, Croatian body has a possible “DuckDuckGoa” typo).Reviewed by Cursor Bugbot for commit e9a50a8. Bugbot is set up for automated code reviews on this repo. Configure here.