Add DaxAppTPBanner composable to the design system - #9762
Open
Kyriakos-Georgiopoulos wants to merge 1 commit into
Open
Add DaxAppTPBanner composable to the design system#9762Kyriakos-Georgiopoulos wants to merge 1 commit into
Kyriakos-Georgiopoulos wants to merge 1 commit into
Conversation
Kyriakos-Georgiopoulos
requested review from
malmstein and
mikescamell
as code owners
September 9, 2026 14:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1215496415658080/task/1211670072973969?focus=true
Tech Design URL (if applicable): N/A
API Proposals URL(s) (if applicable): N/A
Description
Adds the Compose
DaxAppTPBannerto the ADS. It renders aDaxCardwhose whole surface is a single tap target, with the message on the left and a state pictogram on the right:DaxAppTPBanner(text: String, …): plain message.DaxAppTPBanner(text: AnnotatedString, …): for the bolded lead-in the App Tracking Protection states use.DaxAppTPBannerStateselects the pictogram:ProtectedorWarning.The two pictograms move from
vpn-implinto the design system so the component can own them, and the existing AppTP screens now reference them from there.No lint rule: there is no raw Material equivalent to guard against.
Steps to test this PR
ADS catalog
App Tracking Protection screens (the pictograms moved modules)
Maestro
maestro test .maestro/ads_preview_flows/1-_design-system-components.yamlwith the app installedUI
Note
Low Risk
Mostly new Compose UI and drawable relocation with reference updates; no VPN or auth logic changes.
Overview
Introduces
DaxAppTPBannerin the Android Design System: a full-width, tappableDaxCardwith message text (plain orAnnotatedString) and aProtected/Warningpictogram viaDaxAppTPBannerState.AppTP banner assets (
ic_apptp_banner_default,ic_apptp_banner_warning) are centralized in the design system; vpn-impl New Tab, Device Shield, and restore-defaults UI now reference those shared drawables instead of module-local icons.The ADS Messaging catalog gains an App Tracking Protection Banner section (four sample states) plus Maestro scroll/assert steps for the Enabled and Revoked showcase headers.
Reviewed by Cursor Bugbot for commit 5efc562. Bugbot is set up for automated code reviews on this repo. Configure here.