Passkey integration and telemetry - #9756
Open
CDRussell wants to merge 1 commit into
Open
Conversation
CDRussell
force-pushed
the
feature/craig/enable_passkeys_for_all
branch
from
September 9, 2026 13:46
05a46fd to
6d16805
Compare
CDRussell
force-pushed
the
feature/craig/enable_passkeys_for_all
branch
from
September 9, 2026 14:08
6d16805 to
780fbcf
Compare
CDRussell
marked this pull request as ready for review
September 9, 2026 14:11
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1218323434068368 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1215167419281512?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Final steps of
passkeyintegration to prepare for releasing to all users (it's currentlyinternal-only).Steps to test this PR
Testing Patch
We are awaiting an update of CSS lib, so for now to test this you'll need to target a specific CSS branch. You can do so by applying this patch: Patch for testing
TRUE(this will be updated properly by remote config later)Pre-requisites
Create new passkey
playvariantRegister; verify you are prompted to create a passkeyAutofill-passkey: new passkey createdUsing a passkey
Authenticateand verify you are signed in.Autofill-passkey: passkey usedRegistering a second passkey
Try it againto return, and this time enter a different username and tapRegisterSelecting from multiple available passkeys
Authenticate; verify it shows you a selection of passkeys to choose fromCancel out of selecting a passkey
Authenticate; now hit back buttonAutofill-passkey: failure when using passkey: NotAllowedErrorCancel out of creating a passkey
Register; now hit back buttonAutofill-passkey: failure when creating a passkey: NotAllowedErrorStack created with GitHub Stacks CLI • Give Feedback 💬
Note
Low Risk
Telemetry-only path with sanitized, enum-bounded error names; no credential storage or WebAuthn ceremony logic in this diff.
Overview
Adds passkey WebAuthn telemetry by listening for Content Scope Scripts (
webCompat) JS messagespasskeyUsedandpasskeyFailed, parsing ceremony type (getvscreate), and firing matching autofill pixels.Success paths emit count + daily pixels for passkey use and create. Failures attach a bounded
errorparam (allowlisted DOMException names, collapsing unknown/CSSOthertoUnknownError) and use error-specific daily tags. Unparseable notifications fire an unknown event pixel.Pixel catalog updates add five passkey events plus a shared
passkeyErrorparam dictionary entry.autofill-implgainscontent-scope-scripts-apiandjs-messaging-apidependencies for the new handler stack, with unit tests for the parser, pixel sender, and message handler.Reviewed by Cursor Bugbot for commit 780fbcf. Configure here.