Compose: Migrate DaxSlider - #9753
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mikescamell
reviewed
Sep 9, 2026
mikescamell
left a comment
Contributor
There was a problem hiding this comment.
A few Compose API suggestions.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…rate-slider-to-compose # Conflicts: # android-design-system/design-system-internal/src/main/java/com/duckduckgo/common/ui/internal/ui/component/ComponentViewHolder.kt
Member
Author
|
Thanks @mikescamell! I've addressed all your comments. |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1211670072079719?focus=true
Description
Adds the Compose
DaxSliderto the ADS.Also adds the
NoRawM3SliderUsagelint rule (errors on raw Material3Slideroutside the design-system modules; the legacy Viewcom.google.android.material.slider.Slideris untouched) and a showcase in the ADS internal catalog.Steps to test this PR
ADS catalog
DaxSliderrowsNote
Low Risk
New design-system component and lint enforcement only; no production feature flows or security-sensitive logic changed.
Overview
Introduces
DaxSlider, a Compose design-system slider that wraps Material3Sliderwith DuckDuckGo theme colors, a custom thumb, track height from tokens, and no value labels, ticks, or stop indicators. It supports continuous and stepped ranges, disabled state (dimmed via alpha), andonValueChangeFinished.The ADS internal catalog Slider section now shows the legacy View
Material Sliderand a COMPOSE block with three interactiveDaxSliderexamples (continuous, stepped 70–170, disabled), wired throughSliderComponentViewHolderwith theme support.Adds
NoRawM3SliderUsagelint (error onandroidx.compose.material3.Slideroutside design-system modules; Viewcom.google.android.material.slider.Sliderunchanged), registered inDuckDuckGoIssueRegistry, with unit tests.Reviewed by Cursor Bugbot for commit 041f2e7. Bugbot is set up for automated code reviews on this repo. Configure here.