Add origin when launching paywall - #9750
Open
nalcalag wants to merge 1 commit into
Open
Conversation
nalcalag
marked this pull request as ready for review
September 9, 2026 04:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207260194172075/task/1218019265846236?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Attach origin to the URL when SubscriptionsWebViewActivity is launched with an origin param but the URL itself doesn't already contain it
Steps to test this PR
Pre steps
App Settings
origin=funnel_appmenu_androidappended to the URLNo UI changes
Note
Low Risk
Scoped to subscription WebView URL construction and pixel param key naming; origin values remain allowlist-gated with no change to purchase or auth flows.
Overview
Ensures the subscription paywall WebView loads with a funnel
originquery param when launch params carry an allowlisted origin but the target URL does not already include it—so the web offer page can attribute the entry point consistently with native telemetry.Adds
String.appendFunnelOriginParam, which only appendsoriginfor values inFUNNEL_ORIGIN_ALLOWLIST, skips non-hierarchical URLs and URLs that already haveorigin, and is applied on everySubscriptionsWebViewActivityparam resolution path (purchase, upgrade, and default). IntroducesORIGIN_QUERY_PARAM_KEYand replaces hardcoded"origin"strings inRealSubscriptionsandSubscriptionPixelSender; unit tests cover the URL helper.Reviewed by Cursor Bugbot for commit 91b14ce. Bugbot is set up for automated code reviews on this repo. Configure here.