Update password import onboarding pixels - #9746
Open
catalinradoiu wants to merge 2 commits into
Open
Conversation
Report the initial import prompt, the import-complete screen and import failures as separate shown/clicked pixels instead of one pixel carrying a confirmed outcome, and leave the export web flow to its own pixels. The retry alert's buttons now emit their own events so they are no longer indistinguishable from the prompt's Import/Skip CTAs. https://app.asana.com/1/137249556945/project/72649045549333/task/1217265967787217 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
catalinradoiu
force-pushed
the
feature/cradoiu/onboarding-import-pixels
branch
from
September 8, 2026 14:12
908778d to
3e9e40c
Compare
catalinradoiu
marked this pull request as ready for review
September 8, 2026 14:26
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1218276218300847 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1217265967787217
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable): None
Description
The following pixels are now sent for the import passwords step in the linear onboarding.
onboarding_password-importshownclickedengage(Import) /dismiss(Skip)onboarding_password-import-completeshownclickedengage(Continue)onboarding_password-import-errorshowntransient(retry alert) /permanent(failed screen)clickedretry/dismiss(retry alert buttons),engage(Continue on the failed screen)All three carry the usual onboarding params (
installType,daysSinceInstall,flow,pixelSource,variant) and are unique per install per (event, value).Steps to test this PR
Apply the following patch to force the passwords import in the onboarding:
📄 Patch: NewUserOnboardingPlanProvider.kt
Successful import
onboarding_password-importfires withevent=shownevent=clicked, value=engageonboarding_password-import-completefires withevent=shownonce the card resolvesonboarding_password-import-completefires withevent=clicked, value=engageSkipping the prompt
onboarding_password-importfiresevent=clicked, value=dismissand that no complete or error pixel followsTransient failure (retry alert)
Apply the following patch:
📄 Patch: RealImportPasswordsFromGoogle.kt
ImportPasswordsResult.Error.TransientfromRealImportPasswordsFromGoogle)onboarding_password-import-errorfiresevent=shown, value=transientand the retry alert appears over the import cardevent=clicked, value=retry, the web flow relaunches, and no secondonboarding_password-importclicked=engageis firedevent=clicked, value=dismissand that onboarding continues past the import stepPermanent failure
📄 Patch: RealImportPasswordsFromGoogle.kt
Apply the following patch and clean install the app.
onboarding_password-import-errorfiresevent=shown, value=permanentevent=clicked, value=engageCancelling the web flow
Revert the previous changes.
onboarding_password-import-completeor-errorpixel is firedUI changes
Note
Low Risk
Changes are limited to onboarding analytics and event routing; user-facing flow behavior is intentionally preserved with no auth or data-path changes.
Overview
Password import onboarding telemetry is split from one pixel with
confirmedoutcomes into three wire names:onboarding_password-import(initial Import/Skip only),onboarding_password-import-complete(success screen shown + Continue), andonboarding_password-import-error(transient retry alert vs permanent failure, withretry/dismiss/engageclicks). Pixel definitions inonboarding.json5andOnboardingPixelNameare updated to match.The orchestrator and
OnboardingPixelSenderstop emittingPasswordImportConfirmed/event=confirmed; launch and complete steps fire the new pixels at the right lifecycle points (e.g. transient error on web-flow failure, permanent error when the outcome card is failed, no complete/error pixel when the user backs out of the Google export). Retry and Cancel on the error alert use dedicated events (PasswordImportErrorRetryRequested/PasswordImportErrorCancelled) so retry does not double-count an Importengageand cancel on the alert skips the flow without a main-pixel dismiss.Unit tests for the plan provider, pixel sender, and config-driven view model are updated for the new events and parameter values.
Reviewed by Cursor Bugbot for commit 2629eaf. Bugbot is set up for automated code reviews on this repo. Configure here.