Add metrics for the passwords import onboarding experiment - #9743
Open
catalinradoiu wants to merge 2 commits into
Conversation
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1218263807371840 |
Adds the onboarding completion metric for passwordImportExperimentAug25, fired when the user reaches the established stage, plus the import started, success, failed and cancelled metrics. The import metrics fire from the root of the import flow — the web flow view model and the app-scoped import result observer — rather than from each caller, so imports are counted for both cohorts and from every entry point. The experiment lives in the onboarding feature, which autofill-impl cannot depend on, so the toggle is resolved through the feature toggles inventory by name. Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1217594019546143?focus=true Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Registers passwordImportExperimentAug25 and its five metrics under activeExperiments, so the pixels sent by the native experiments framework are documented. Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1217594019546143?focus=true Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
catalinradoiu
force-pushed
the
feature/cradoiu/define-metrics-for-passwords-import-experiment
branch
from
September 10, 2026 06:54
c8ffbae to
3e3519e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1217594019546143?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable): None
Description
Adds the experiment metrics for onboarding passwords import experiment.
onboarding_completedpassword_import_startedpassword_import_successpassword_import_failedpassword_import_cancelledSteps to test this PR
The wire pixels are
experiment_enroll_passwordImportExperimentAug25_<cohort>andexperiment_metrics_passwordImportExperimentAug25_<cohort>, the latter carrying the metric in ametric=param.logs
message~:"passwordImportExperimentAug25".setup
no experiment
disabled).DuckDuckGofolder from the device's DownloadspasswordImportExperimentAug25pixels fire at all — no enrollment and no metrics.control
controlweight1andtreatmentweight0in both files.DuckDuckGofolder from the device's Downloads.experiment_enroll_passwordImportExperimentAug25_controlfires.metric=onboarding_completed.metric=password_import_started.metric=password_import_success.metric=password_import_cancelled.treatment
controlweight to0andtreatmentweight to1in bothprivacy_config.jsonthen rebuild.DuckDuckGofolder from the device's Downloads.experiment_enroll_passwordImportExperimentAug25_treatmentfires.metric=password_import_started.metric=password_import_success, and that the outcome card shows the imported/skipped counts.metric=onboarding_completed.metric=password_import_cancelledand that you land back on the import card.password_import_startedfires.reinstaller
DuckDuckGofolder from Downloads.passwordImportExperimentAug25enrollment or metric pixels fire.UI changes
Note
Low Risk
Analytics-only changes on existing onboarding and import flows; no user-facing behavior or credential handling logic changes.
Overview
Adds native experiment instrumentation for
passwordImportExperimentAug25, wiring five conversion metrics (d0 and d0–14) for onboarding completion and Google password import funnel events.Registers the experiment and metric definitions in
native_experiments.json5. When the user reaches ESTABLISHED,OnboardingCompletedMetricObservernow also firesonboarding_completedviaOnboardingPasswordImportExperimentMetrics(alongside the existing prompts experiment).In autofill, new
PasswordImportExperimentMetricssendspassword_import_started,password_import_success,password_import_failed, andpassword_import_cancelledfrom the Google import web flow and fromImportPasswordsResultPixelObserveron successful import completion. The autofill module resolves the experiment toggle by name throughFeatureTogglesInventoryto avoid a dependency on the onboarding feature module.Unit tests cover metric payloads, observer wiring, and view-model trigger points.
Reviewed by Cursor Bugbot for commit 3e3519e. Bugbot is set up for automated code reviews on this repo. Configure here.