Skip to content

[Segmented Onboarding] Bundle of minor Ship Review updates - #9736

Merged
LukasPaczos merged 4 commits into
feature/lpaczos/segmented-onboarding/experiment-and-metricsfrom
feature/lpaczos/segmented-onboarding/ship-review-minor-bundle
Sep 11, 2026
Merged

LukasPaczos merged 4 commits into
feature/lpaczos/segmented-onboarding/experiment-and-metricsfrom
feature/lpaczos/segmented-onboarding/ship-review-minor-bundle

Conversation

@LukasPaczos

@LukasPaczos LukasPaczos commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1218242333557028?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):

Description

  • Add forced line breaks to the choice screen tiles' copies.
  • Update copy on the model picker step to mentioned "providers".
  • Change the delay of tile click animation to 100ms.
  • Align sizes of comparison chart logos.

Steps to test this PR

QA optional.

UI changes

Before After
image image
image image

Note

Low Risk
Onboarding-only layout, strings, drawable, and animation delay changes with no auth, data, or core browsing impact.

Overview
Ship-review polish for segmented onboarding UI and copy.

The download-reason tiles now use forced line breaks in their labels (including renaming the no-AI option to “Disable AI features”), and the Lottie selection animation starts after 100ms instead of 300ms. On the AI path, the model-picker body now says “AI provider” instead of “AI”.

The onboarding comparison chart aligns both header logos at 31.5dp, wires the Duck side through comparisonChartHeaderRightIcon, and swaps logo_medium for a new design-system drawable ddg_logo_full_bleed so the DDG mark fills the orange card consistently with Chrome on the left.

Reviewed by Cursor Bugbot for commit c2344a6. Bugbot is set up for automated code reviews on this repo. Configure here.

@LukasPaczos
LukasPaczos marked this pull request as ready for review September 10, 2026 14:28

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@mikescamell mikescamell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasPaczos
LukasPaczos added this pull request to the merge queue Sep 11, 2026
Merged via the queue into develop with commit 05c495d Sep 11, 2026
28 of 30 checks passed
@LukasPaczos
LukasPaczos deleted the feature/lpaczos/segmented-onboarding/ship-review-minor-bundle branch September 11, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants