Enable R8 optimization - #9716
Open
joshliebe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1200204095367872/task/1218149406979969?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Steps to test this PR
Note
Low Risk
Single Gradle default-rules swap with release minification still disabled; main risk is unexpected shrink/obfuscation behavior when minify is later enabled without sufficient keep rules.
Overview
The release build type in
app/build.gradlenow pointsproguardFilesatproguard-android-optimize.txtinstead ofproguard-android.txt, matching the pattern already used ingradle/android-library.gradle.That default ruleset turns on additional R8 shrinking and optimization beyond the non-optimize file.
minifyEnabledis stillfalsefor release in this diff, so the new rules only affect builds once release minification/R8 is actually enabled (or if another flag turns it on elsewhere).Reviewed by Cursor Bugbot for commit 3830ce1. Bugbot is set up for automated code reviews on this repo. Configure here.