Count a Duck.ai prompt toward the search experiment metric - #9710
Open
LukasPaczos wants to merge 2 commits into
Open
Count a Duck.ai prompt toward the search experiment metric#9710LukasPaczos wants to merge 2 commits into
LukasPaczos wants to merge 2 commits into
Conversation
LukasPaczos
force-pushed
the
fix/lpaczos/count-prompts-toward-search-metric
branch
from
September 4, 2026 09:05
8df7afa to
37fbf5f
Compare
marcosholgado
left a comment
Contributor
There was a problem hiding this comment.
Added a couple of comments, not sure this needs to have this complexity.
LukasPaczos
force-pushed
the
fix/lpaczos/count-prompts-toward-search-metric
branch
from
September 4, 2026 09:43
e50e06f to
493b912
Compare
Base automatically changed from
feature/lpaczos/duck-ai-new-chat-metric
to
develop
September 4, 2026 09:59
LukasPaczos
force-pushed
the
fix/lpaczos/count-prompts-toward-search-metric
branch
from
September 4, 2026 09:59
493b912 to
dd77be9
Compare
marcosholgado
approved these changes
Sep 7, 2026
marcosholgado
left a comment
Contributor
There was a problem hiding this comment.
LGTM but let's wait to get the go ahead from DS just in case we also need to do something with atb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1216793387267215?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Aligns expected retention metrics with other platform by counting Duck.ai prompts towards the search metric.
To avoid impacting in-flight experiments, any active experiment from the current local/remote config is excluded.
Steps to test this PR
Verify unit tests, and that they pass on CI.
Note
Medium Risk
Changes when search retention pixels fire for experiments; a wrong or incomplete exclusion list could distort in-flight experiment metrics.
Overview
Duck.ai ATB refresh now also fires search retention metrics, alongside existing
duck_ai_prompt_sentpixels, so Duck.ai prompt activity is counted toward search experiment retention like other platforms.Search metrics are filtered on the Duck.ai path only: experiments listed in
EXPERIMENTS_EXCLUDED_FROM_DUCK_AI_SEARCH_METRIC(currentlyaddToDockAndWidgetExperimentJul25) are skipped so pre-existing in-flight experiments are not skewed. Search ATB refresh is unchanged—those experiments still get search metrics there.Unit tests cover dual-metric sends on Duck.ai refresh, the exclusion on Duck.ai, and unchanged behavior on search refresh.
Reviewed by Cursor Bugbot for commit dd77be9. Bugbot is set up for automated code reviews on this repo. Configure here.