Skip to content

Count a Duck.ai prompt toward the search experiment metric - #9710

Open
LukasPaczos wants to merge 2 commits into
developfrom
fix/lpaczos/count-prompts-toward-search-metric
Open

Count a Duck.ai prompt toward the search experiment metric#9710
LukasPaczos wants to merge 2 commits into
developfrom
fix/lpaczos/count-prompts-toward-search-metric

Conversation

@LukasPaczos

@LukasPaczos LukasPaczos commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1216793387267215?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):

Description

Aligns expected retention metrics with other platform by counting Duck.ai prompts towards the search metric.

To avoid impacting in-flight experiments, any active experiment from the current local/remote config is excluded.

Steps to test this PR

Verify unit tests, and that they pass on CI.


Note

Medium Risk
Changes when search retention pixels fire for experiments; a wrong or incomplete exclusion list could distort in-flight experiment metrics.

Overview
Duck.ai ATB refresh now also fires search retention metrics, alongside existing duck_ai_prompt_sent pixels, so Duck.ai prompt activity is counted toward search experiment retention like other platforms.

Search metrics are filtered on the Duck.ai path only: experiments listed in EXPERIMENTS_EXCLUDED_FROM_DUCK_AI_SEARCH_METRIC (currently addToDockAndWidgetExperimentJul25) are skipped so pre-existing in-flight experiments are not skewed. Search ATB refresh is unchanged—those experiments still get search metrics there.

Unit tests cover dual-metric sends on Duck.ai refresh, the exclusion on Duck.ai, and unchanged behavior on search refresh.

Reviewed by Cursor Bugbot for commit dd77be9. Bugbot is set up for automated code reviews on this repo. Configure here.

@LukasPaczos
LukasPaczos force-pushed the fix/lpaczos/count-prompts-toward-search-metric branch from 8df7afa to 37fbf5f Compare September 4, 2026 09:05

@marcosholgado marcosholgado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments, not sure this needs to have this complexity.

@LukasPaczos
LukasPaczos force-pushed the fix/lpaczos/count-prompts-toward-search-metric branch from e50e06f to 493b912 Compare September 4, 2026 09:43
Base automatically changed from feature/lpaczos/duck-ai-new-chat-metric to develop September 4, 2026 09:59
@LukasPaczos
LukasPaczos force-pushed the fix/lpaczos/count-prompts-toward-search-metric branch from 493b912 to dd77be9 Compare September 4, 2026 09:59

@marcosholgado marcosholgado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait to get the go ahead from DS just in case we also need to do something with atb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants