Skip to content

Use real Literal::from_str from libproc_macro#296

Merged
dtolnay merged 1 commit into
masterfrom
literalfromstr
Aug 30, 2021
Merged

Use real Literal::from_str from libproc_macro#296
dtolnay merged 1 commit into
masterfrom
literalfromstr

Conversation

@dtolnay

@dtolnay dtolnay commented Aug 30, 2021

Copy link
Copy Markdown
Owner

Closes #287 now that rust-lang/rust#84717 has made it into a stable Rust release.

@alamb

alamb commented Sep 9, 2021

Copy link
Copy Markdown

FYI this broke a downstream project (apache/datafusion#961) when released, and looks like a few others as well (see the open issues linked)

Our fix was to pin to 1.0.28

@alamb

alamb commented Sep 9, 2021

Copy link
Copy Markdown

(thank you for all your work on the proc-macro2 crate, BTW -- we likely take much of this work for granted but it is appreciated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use proc_macro's impl FromStr for Literal once Rust 1.53 is stable

2 participants