Repository navigation
Fixes to fenrir realm - #3130
Merged
dteviot merged 6 commits intoNov 11, 2026
Merged
Conversation
matthewsong18
commented
Nov 9, 2026
matthewsong18
commented
Contributor
- Added @jurassicplayer's fix from Fix 20261107 fenrirrealm idtouuid #3127, but since they didn't remove the GH Action incrementing the version, I just moved their commit here. I think they still get credit if they're the author of the commit. If this isn't true, I'll just rebase after their PR.
- Replaced the regex with an empty string check. We don't need the uuid to be valid since we're just looking for an id that we can use. This should prevent the parser from breaking if the uuid changes to be an invalid uuid format, since being valid didn't matter to us.
- Fixed a bug in selecting chapters due to null data in the chapter data. Swapped to adding all chapters by default and unselecting paid or scheduled chapters to counter bad data.
- Moved the delay before closing a chapter tab from after the text capture to before. We need the delay because closing before a second validation request, running in the background, finishes forces the user to re-validate next chapter. Since we're waiting anyways, I moved it before the capture to give more time for the page to load after the observer thinks the page is ready.
- Tried to update the comments to explain why some things are happening, like why we're using tabs or why there is a delay on each tab.
We don't really need a regex here. Just checking for a nonempty string is sufficient. We don't care if the uuid is a valid uuid. As long as we can id the chapter.
Encountered a novel where the release date was just null for some chapters causing an issue where those chapters would not be selected by default, even if they met the criteria for downloading. Because of this, I swapped the default selection to selecting by default and instead unselecting chapters that met the criteria for being locked or still scheduled.
We have to delay before closing the tab because a second validation request is happening. If we close before that request, even if we already have the chapter content, the user has to validate again next chapter. Since we have to wait anyways, moved delay before chapter capture just in-case something needs to settle a bit.
Not sure why this didn't format earlier
dteviot
reviewed
Nov 11, 2026
| chapterId, | ||
| true, | ||
| ); | ||
| installation.then( |
Owner
There was a problem hiding this comment.
Could probably use await syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.