Forge: address publication review feedback - #37
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8cf0691-0fe3-4d67-92ce-ce2a529c400c
There was a problem hiding this comment.
Pull request overview
This PR updates the Repository Skill Forge workflow to make publication metadata deterministic per selected proposal, harden/clarify publication guidance around marker storage, and improve extraction retry behavior when tool batches cannot be split further.
Changes:
- Emit
selection.markerdirectly from the selected proposal duringproposal-ledger.py select, and validate it in the stateless forge tests. - When a tools batch failure occurs and it cannot be split (single session), fall back to reducing the page size (with a new regression test).
- Update Skill/prompt documentation to store markers per-proposal and to require using the selected proposal’s marker for PR publication.
Show a summary per file
| File | Description |
|---|---|
| plugins/repo-dreamer/skills/repository-skill-forge/tests/test_stateless_forge.py | Adds an assertion that selection.marker matches the selected proposal’s rendered marker. |
| plugins/repo-dreamer/skills/repository-skill-forge/tests/test_extraction_controller.py | Adds a regression test ensuring single-session tool failures reduce pageSize instead of only attempting splits. |
| plugins/repo-dreamer/skills/repository-skill-forge/SKILL.md | Updates guidance to store markers per proposal directory and to use selection.marker for publication. |
| plugins/repo-dreamer/skills/repository-skill-forge/scripts/proposal-ledger.py | Extends select() output so the chosen selection includes marker derived from the selected proposal. |
| plugins/repo-dreamer/skills/repository-skill-forge/scripts/extraction-controller.py | Adjusts failure recovery so tools batches attempt split_tool_batch() and otherwise fall back to split_batch() (page size reduction). |
| plugins/repo-dreamer/skills/repository-skill-forge/prompts/author-proposal.md | Aligns authoring/publication instructions with the per-proposal marker storage + selection.marker usage. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checkpassesMirrors the follow-up fixes applied to github/copilot-dreaming-tasks#24.