Skip to content

Forge: address publication review feedback - #37

Merged
GolaraJ merged 1 commit into
mainfrom
fix/forge-pr24-review-followups
Aug 19, 2026
Merged

Forge: address publication review feedback#37
GolaraJ merged 1 commit into
mainfrom
fix/forge-pr24-review-followups

Conversation

@GolaraJ

@GolaraJ GolaraJ commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • bind the published PR marker to the selected proposal
  • reject symlinks at every mapped publication destination
  • reduce tool page size when a single-session batch cannot split further

Validation

  • 74 Repository Skill Forge tests pass
  • git diff --check passes

Mirrors the follow-up fixes applied to github/copilot-dreaming-tasks#24.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b8cf0691-0fe3-4d67-92ce-ce2a529c400c

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Repository Skill Forge workflow to make publication metadata deterministic per selected proposal, harden/clarify publication guidance around marker storage, and improve extraction retry behavior when tool batches cannot be split further.

Changes:

  • Emit selection.marker directly from the selected proposal during proposal-ledger.py select, and validate it in the stateless forge tests.
  • When a tools batch failure occurs and it cannot be split (single session), fall back to reducing the page size (with a new regression test).
  • Update Skill/prompt documentation to store markers per-proposal and to require using the selected proposal’s marker for PR publication.
Show a summary per file
File Description
plugins/repo-dreamer/skills/repository-skill-forge/tests/test_stateless_forge.py Adds an assertion that selection.marker matches the selected proposal’s rendered marker.
plugins/repo-dreamer/skills/repository-skill-forge/tests/test_extraction_controller.py Adds a regression test ensuring single-session tool failures reduce pageSize instead of only attempting splits.
plugins/repo-dreamer/skills/repository-skill-forge/SKILL.md Updates guidance to store markers per proposal directory and to use selection.marker for publication.
plugins/repo-dreamer/skills/repository-skill-forge/scripts/proposal-ledger.py Extends select() output so the chosen selection includes marker derived from the selected proposal.
plugins/repo-dreamer/skills/repository-skill-forge/scripts/extraction-controller.py Adjusts failure recovery so tools batches attempt split_tool_batch() and otherwise fall back to split_batch() (page size reduction).
plugins/repo-dreamer/skills/repository-skill-forge/prompts/author-proposal.md Aligns authoring/publication instructions with the per-proposal marker storage + selection.marker usage.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 6/6 changed files
  • Comments generated: 0
  • Review effort level: Lite

@GolaraJ
GolaraJ merged commit 2875a36 into main Aug 19, 2026
1 check passed
@GolaraJ
GolaraJ deleted the fix/forge-pr24-review-followups branch August 19, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants