Forge: materialize tool-call actions - #21
Merged
Merged
Conversation
Use the extraction controller's canonical tool-calls action kind in the result materializer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8cf0691-0fe3-4d67-92ce-ce2a529c400c
There was a problem hiding this comment.
Pull request overview
Updates the session-query materializer and its end-to-end “spilled tool-result” test to align with the extraction controller’s canonical action kind (tool-calls), resolving a contract mismatch where the controller emitted tool-calls but the materializer expected tools.
Changes:
- Switch materialization parsing to recognize the
tool-callsaction kind and its expected result columns. - Update the spilled tool-result integration test fixture to emit
kind: "tool-calls"inactions.json.
Show a summary per file
| File | Description |
|---|---|
| plugins/repo-dreamer/skills/repository-skill-forge/tests/test_materialize_session_query.py | Updates the test action fixture to use the controller’s tool-calls kind. |
| plugins/repo-dreamer/skills/repository-skill-forge/scripts/materialize-session-query.py | Renames the parsed action kind from tools to tool-calls (both header expectations and row parsing branch). |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool-callsaction kindRoot cause
The result was found successfully after PR #20, but the materializer rejected the action before parsing because it expected
toolswhileextraction-controller.pyemitstool-calls.Validation
git diff --checkpasses