Skip to content

Forge: materialize tool-call actions - #21

Merged
GolaraJ merged 1 commit into
mainfrom
fix/forge-tool-action-kind
Aug 18, 2026
Merged

Forge: materialize tool-call actions#21
GolaraJ merged 1 commit into
mainfrom
fix/forge-tool-action-kind

Conversation

@GolaraJ

@GolaraJ GolaraJ commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • recognize the extraction controller’s canonical tool-calls action kind
  • update the end-to-end spilled tool-result test to use the real controller contract

Root cause

The result was found successfully after PR #20, but the materializer rejected the action before parsing because it expected tools while extraction-controller.py emits tool-calls.

Validation

  • 43 Skill Forge tests pass
  • Python scripts compile
  • git diff --check passes

Use the extraction controller's canonical tool-calls action kind in the result materializer.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b8cf0691-0fe3-4d67-92ce-ce2a529c400c
@GolaraJ
GolaraJ merged commit dd6457d into main Aug 18, 2026
@GolaraJ
GolaraJ requested a lite review from Copilot August 18, 2026 04:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the session-query materializer and its end-to-end “spilled tool-result” test to align with the extraction controller’s canonical action kind (tool-calls), resolving a contract mismatch where the controller emitted tool-calls but the materializer expected tools.

Changes:

  • Switch materialization parsing to recognize the tool-calls action kind and its expected result columns.
  • Update the spilled tool-result integration test fixture to emit kind: "tool-calls" in actions.json.
Show a summary per file
File Description
plugins/repo-dreamer/skills/repository-skill-forge/tests/test_materialize_session_query.py Updates the test action fixture to use the controller’s tool-calls kind.
plugins/repo-dreamer/skills/repository-skill-forge/scripts/materialize-session-query.py Renames the parsed action kind from tools to tool-calls (both header expectations and row parsing branch).

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

@GolaraJ
GolaraJ deleted the fix/forge-tool-action-kind branch August 18, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants