Skip to content

docs: add Javadoc to public and protected API - #1442

Merged
joaodinissf merged 4 commits into
dsldevkit:masterfrom
joaodinissf:chore/require-public-protected-javadoc
Jul 13, 2026
Merged

docs: add Javadoc to public and protected API#1442
joaodinissf merged 4 commits into
dsldevkit:masterfrom
joaodinissf:chore/require-public-protected-javadoc

Conversation

@joaodinissf

@joaodinissf joaodinissf commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

What

Documents the public and protected methods that a MissingJavadocMethod audit surfaced — 51 methods across 21 files, grouped into four area commits (check, checkcfg, xtext, samples). The diff is pure additions (+327, 0 deletions): only Javadoc comments; no code or signatures touched.

The audit rule itself (MissingJavadocMethod, public+protected, methods only, trivial-accessor and @Override/@Inject exemptions) is not enabled here — checkstyle cannot see .xtend files, so the ongoing Xtend-to-Java migration exposes previously-invisible undocumented API with every merged wave, and the gate would go red after each one. Enablement is deferred to #1466, after the migration completes.

How the docs were written

Each flagged method gets a simple, accurate Javadoc: a one-sentence summary plus the @param/@return/@throws tags the existing content rules require. Descriptions are terse and derived from the signature/obvious behaviour — no speculation, no boilerplate name-restatement. Example:

/**
 * Returns whether references held by the given object via the given feature should be indexed.
 *
 * @param from
 *          the object holding the reference
 * @param eReference
 *          the reference feature to test
 * @return {@code true} unless the reference is a containment or container reference
 */
protected boolean isIndexable(final EObject from, final EReference eReference) { ... }

Verification

  • Full local gate (verify + checkstyle + pmd + cpd + spotbugs) green on current master.
  • The added Javadoc is validated by the existing JavadocMethod content rules.

🤖 Generated with Claude Code

@joaodinissf
joaodinissf force-pushed the chore/require-public-protected-javadoc branch from c4dcc25 to 04fc352 Compare June 21, 2026 10:02
@joaodinissf joaodinissf changed the title build(checkstyle): require Javadoc on public/protected methods + document the API build(checkstyle): require Javadoc on public/protected methods + document them Jun 21, 2026
@joaodinissf
joaodinissf force-pushed the chore/require-public-protected-javadoc branch 3 times, most recently from ac59fb2 to 1b2bc5f Compare June 21, 2026 18:46
@joaodinissf
joaodinissf force-pushed the chore/require-public-protected-javadoc branch from 1b2bc5f to 4b1918a Compare July 7, 2026 15:53
joaodinissf and others added 2 commits July 11, 2026 22:15
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@joaodinissf joaodinissf changed the title build(checkstyle): require Javadoc on public/protected methods + document them docs: add Javadoc to public and protected API Jul 11, 2026
@joaodinissf
joaodinissf force-pushed the chore/require-public-protected-javadoc branch from 4b1918a to 04317f1 Compare July 11, 2026 20:20
@joaodinissf
joaodinissf marked this pull request as ready for review July 11, 2026 20:25
@joaodinissf
joaodinissf requested a review from rubenporras July 11, 2026 20:25
joaodinissf and others added 2 commits July 11, 2026 22:32
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@joaodinissf
joaodinissf force-pushed the chore/require-public-protected-javadoc branch from 04317f1 to c9dd4a1 Compare July 11, 2026 20:37
@rubenporras

Copy link
Copy Markdown
Member

something is wrong in the CI/CD setup, we should enforce this with PMD or Checkstyle, in case you want to chase it further

@joaodinissf
joaodinissf merged commit c71cbae into dsldevkit:master Jul 13, 2026
4 checks passed
@joaodinissf
joaodinissf deleted the chore/require-public-protected-javadoc branch July 13, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants