docs: add Javadoc to public and protected API - #1442
Merged
joaodinissf merged 4 commits intoJul 13, 2026
Merged
Conversation
joaodinissf
force-pushed
the
chore/require-public-protected-javadoc
branch
from
June 21, 2026 10:02
c4dcc25 to
04fc352
Compare
joaodinissf
force-pushed
the
chore/require-public-protected-javadoc
branch
3 times, most recently
from
June 21, 2026 18:46
ac59fb2 to
1b2bc5f
Compare
joaodinissf
force-pushed
the
chore/require-public-protected-javadoc
branch
from
July 7, 2026 15:53
1b2bc5f to
4b1918a
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
chore/require-public-protected-javadoc
branch
from
July 11, 2026 20:20
4b1918a to
04317f1
Compare
joaodinissf
marked this pull request as ready for review
July 11, 2026 20:25
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
chore/require-public-protected-javadoc
branch
from
July 11, 2026 20:37
04317f1 to
c9dd4a1
Compare
rubenporras
approved these changes
Jul 13, 2026
Member
|
something is wrong in the CI/CD setup, we should enforce this with PMD or Checkstyle, in case you want to chase it further |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Documents the public and protected methods that a
MissingJavadocMethodaudit surfaced — 51 methods across 21 files, grouped into four area commits (check, checkcfg, xtext, samples). The diff is pure additions (+327, 0 deletions): only Javadoc comments; no code or signatures touched.The audit rule itself (
MissingJavadocMethod, public+protected, methods only, trivial-accessor and@Override/@Injectexemptions) is not enabled here — checkstyle cannot see.xtendfiles, so the ongoing Xtend-to-Java migration exposes previously-invisible undocumented API with every merged wave, and the gate would go red after each one. Enablement is deferred to #1466, after the migration completes.How the docs were written
Each flagged method gets a simple, accurate Javadoc: a one-sentence summary plus the
@param/@return/@throwstags the existing content rules require. Descriptions are terse and derived from the signature/obvious behaviour — no speculation, no boilerplate name-restatement. Example:Verification
JavadocMethodcontent rules.🤖 Generated with Claude Code